chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java - Issue 2320573002: Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2320573002: Move onBindViewHolder from NewTabPageViewHolder to NewTabPageItem. (Closed)

Patch Set: review Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AboveTheFoldItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

index 5bc2cfe544a8fa6e79f3f8f7aa9a52cdf6e4318a..e021b3538e84a1826ae78190a469bd04f9de1faa 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

@@ -81,10 +81,14 @@ class ActionItem implements NewTabPageItem {

});

}

- @Override

- public void onBindViewHolder(NewTabPageItem item) {

- super.onBindViewHolder(item);

- mActionListItem = (ActionItem) item;

+ public void onBindViewHolder(ActionItem item) {

+ mActionListItem = item;

}

+ @Override

+ public void onBindViewHolder(NewTabPageViewHolder holder) {

+ assert holder instanceof ViewHolder;

+ ((ViewHolder) holder).onBindViewHolder(this);

+ }

}