Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2318673003: Revert of GN(Android): Stop specifying depfile under outputs (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GN(Android): Stop specifying depfile under outputs (patchset #2 id:20001 of https://codereview.chromium.org/2305283002/ ) Reason for revert: Reverting due to builder compile failure: https://build.chromium.org/p/chromium/builders/Android/builds/61823 Original issue's description: > GN(Android): Stop specifying depfile under outputs > > Doing so is unnecessary (GN already knows that depfiles are generated by > their target), and causes the unwanted side-effect of changes to .d > files triggering rebuilds of dependent targets. > > BUG=639042 > > Committed: https://crrev.com/fd47b4e4232b99dfb4044b79eea66a7e6b2c2a64 > Cr-Commit-Position: refs/heads/master@{#416710} TBR=michaelbai@chromium.org,dpranke@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=639042 Committed: https://crrev.com/6a8a144fdd34dcb08a14765c743d9b2abb113898 Cr-Commit-Position: refs/heads/master@{#416735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -25 lines) Patch
M android_webview/BUILD.gn View 3 chunks +3 lines, -5 lines 0 comments Download
M build/config/android/internal_rules.gni View 17 chunks +18 lines, -5 lines 0 comments Download
M build/config/android/rules.gni View 14 chunks +14 lines, -1 line 0 comments Download
M chrome/android/BUILD.gn View 6 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
lushnikov
Created Revert of GN(Android): Stop specifying depfile under outputs
4 years, 3 months ago (2016-09-06 21:59:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318673003/1
4 years, 3 months ago (2016-09-06 21:59:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 22:00:46 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a8a144fdd34dcb08a14765c743d9b2abb113898 Cr-Commit-Position: refs/heads/master@{#416735}
4 years, 3 months ago (2016-09-06 22:02:23 UTC) #7
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2315993003/ by agrieve@chromium.org. ...
4 years, 3 months ago (2016-09-07 02:27:48 UTC) #8
Dirk Pranke
4 years, 3 months ago (2016-09-08 21:56:47 UTC) #9
Message was sent while issue was closed.
(lgtm)

Powered by Google App Engine
This is Rietveld 408576698