Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2315993003: Reland of GN(Android): Stop specifying depfile under outputs (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of GN(Android): Stop specifying depfile under outputs Previous attempt: https://codereview.chromium.org/2318673003/ ) Reason for reland: Now creates depfile parent directory Doing so is unnecessary (GN already knows that depfiles are generated by their target), and causes the unwanted side-effect of changes to .d files triggering rebuilds of dependent targets. TBR=michaelbai@chromium.org,dpranke@chromium.org,lushnikov@chromium.org BUG=639042 Committed: https://crrev.com/daef66ba0e2326d524e6429afdbb282b750c0ecc Cr-Commit-Position: refs/heads/master@{#416930}

Patch Set 1 #

Patch Set 2 : Create depfile parent directory when it doesn't exist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -48 lines) Patch
M android_webview/BUILD.gn View 1 3 chunks +5 lines, -3 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 17 chunks +5 lines, -18 lines 0 comments Download
M build/config/android/rules.gni View 1 14 chunks +1 line, -14 lines 0 comments Download
M chrome/android/BUILD.gn View 1 6 chunks +14 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
agrieve
Created Reland of GN(Android): Stop specifying depfile under outputs
4 years, 3 months ago (2016-09-07 02:27:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315993003/130001
4 years, 3 months ago (2016-09-07 14:06:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:130001)
4 years, 3 months ago (2016-09-07 14:10:22 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/daef66ba0e2326d524e6429afdbb282b750c0ecc Cr-Commit-Position: refs/heads/master@{#416930}
4 years, 3 months ago (2016-09-07 14:12:27 UTC) #12
Dirk Pranke
4 years, 3 months ago (2016-09-07 16:33:34 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698