Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/android/BUILD.gn

Issue 2318673003: Revert of GN(Android): Stop specifying depfile under outputs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index 771fe0fc1dc06feffcc75c05dff9be6b9e40288e..9c37ab871d50a833c23fbadb8a42137fa640c741 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -18,18 +18,14 @@
chrome_public_jinja_variables = default_chrome_public_jinja_variables +
[ "manifest_package=$manifest_package" ]
-chrome_public_android_manifest =
- "$target_gen_dir/chrome_public_apk/AndroidManifest.xml"
-chrome_sync_shell_android_manifest =
- "$target_gen_dir/chrome_sync_shell_apk/AndroidManifest.xml"
chrome_sync_shell_jinja_variables =
default_chrome_public_jinja_variables +
[ "manifest_package=org.chromium.chrome.sync_shell" ]
-jinja_template("chrome_public_android_manifest") {
+jinja_template("chrome_public_apk_manifest") {
input = "java/AndroidManifest.xml"
- output = chrome_public_android_manifest
+ output = "$root_gen_dir/chrome_public_apk_manifest/AndroidManifest.xml"
variables = chrome_public_jinja_variables
variables += [
"min_sdk_version=16",
@@ -37,9 +33,9 @@
]
}
-jinja_template("chrome_sync_shell_android_manifest") {
+jinja_template("chrome_sync_shell_apk_manifest") {
input = "java/AndroidManifest.xml"
- output = chrome_sync_shell_android_manifest
+ output = "$root_gen_dir/chrome_sync_shell_apk_manifest/AndroidManifest.xml"
variables = chrome_sync_shell_jinja_variables
variables += [
"min_sdk_version=16",
@@ -174,7 +170,7 @@
android_library("chrome_java") {
deps = [
- ":chrome_public_android_manifest",
+ ":chrome_public_apk_manifest",
":chrome_public_apk_template_resources",
"//base:base_java",
"//chrome/android/webapk/libs/client:client_java",
@@ -234,7 +230,8 @@
jar_excluded_patterns = [ "*/BuildConfig.class" ]
# Manifest used for linting (determining unused resources).
- android_manifest = chrome_public_android_manifest
+ android_manifest = get_target_outputs(":chrome_public_apk_manifest")
+ android_manifest = android_manifest[1]
# TODO(sievers): Split java code into components. Not everything
# is really all that UI related here.
@@ -584,8 +581,9 @@
}
chrome_public_apk_tmpl_shared("chrome_public_apk") {
- android_manifest = chrome_public_android_manifest
- android_manifest_dep = ":chrome_public_android_manifest"
+ android_manifest = get_target_outputs(":chrome_public_apk_manifest")
+ android_manifest = android_manifest[1]
+ android_manifest_dep = ":chrome_public_apk_manifest"
apk_name = "ChromePublic"
shared_libraries = [ ":chrome" ]
@@ -594,8 +592,9 @@
chrome_public_apk_tmpl_shared("chrome_sync_shell_apk") {
testonly = true
- android_manifest = chrome_sync_shell_android_manifest
- android_manifest_dep = ":chrome_sync_shell_android_manifest"
+ android_manifest = get_target_outputs(":chrome_sync_shell_apk_manifest")
+ android_manifest = android_manifest[1]
+ android_manifest_dep = ":chrome_sync_shell_apk_manifest"
apk_name = "ChromeSyncShell"
shared_libraries = [ ":chrome_sync_shell" ]
« no previous file with comments | « build/config/android/rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698