Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2487)

Unified Diff: build/config/android/internal_rules.gni

Issue 2318673003: Revert of GN(Android): Stop specifying depfile under outputs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/BUILD.gn ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 14554cb4d1b7a2f02263320f1dcd0b0bba62a1b9..db0c06185bfd8fc0b3adc2ad43ac6c477f1f1d94 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -151,6 +151,7 @@
_rebased_deps_configs = rebase_path(_deps_configs, root_build_dir)
outputs = [
+ depfile,
build_config,
]
@@ -385,18 +386,15 @@
sources = []
}
script = "//build/android/gyp/copy_ex.py"
+
depfile = "$target_gen_dir/$target_name.d"
-
- _stamp_file = "$target_gen_dir/$target_name.stamp"
outputs = [
- _stamp_file,
+ depfile,
]
args = [
"--depfile",
rebase_path(depfile, root_build_dir),
- "--stamp",
- rebase_path(_stamp_file, root_build_dir),
"--dest",
rebase_path(invoker.dest, root_build_dir),
]
@@ -612,6 +610,7 @@
generated_script = "$root_build_dir/bin/run_${_test_name}"
outputs = [
+ depfile,
generated_script,
]
data += [ generated_script ]
@@ -678,6 +677,7 @@
]
outputs = [
+ depfile,
_config_path,
_result_path,
]
@@ -769,6 +769,7 @@
}
depfile = "${target_gen_dir}/${target_name}.d"
outputs = [
+ depfile,
_output_jar_path,
"$_output_jar_path.dump",
"$_output_jar_path.seeds",
@@ -821,6 +822,7 @@
]
outputs = [
+ depfile,
_result_path,
]
@@ -868,6 +870,7 @@
_build_config,
]
outputs = [
+ depfile,
java_script,
]
forward_variables_from(invoker, [ "deps" ])
@@ -928,6 +931,7 @@
main_dex_rules = "//build/android/main_dex_classes.flags"
outputs = [
+ depfile,
_main_dex_list_path,
]
@@ -964,6 +968,7 @@
script = "//build/android/gyp/dex.py"
depfile = "$target_gen_dir/$target_name.d"
outputs = [
+ depfile,
invoker.output,
]
@@ -1155,6 +1160,7 @@
invoker.input_jar_path,
]
outputs = [
+ depfile,
_coverage_file,
_source_dirs_listing_file,
invoker.output_jar_path,
@@ -1229,6 +1235,7 @@
}
outputs = [
+ depfile,
invoker.output_apk_path,
]
@@ -1325,6 +1332,7 @@
invoker.keystore_path,
]
outputs = [
+ depfile,
invoker.output_apk_path,
]
data = [
@@ -1461,6 +1469,7 @@
inputs += [ _resources_zip ]
}
outputs = [
+ depfile,
invoker.resource_packaged_apk_path,
]
@@ -1555,6 +1564,7 @@
_android_manifest,
]
outputs = [
+ depfile,
_incremental_android_manifest,
]
@@ -1989,6 +1999,7 @@
}
outputs = [
+ depfile,
_javac_jar_path,
_javac_jar_path + ".md5.stamp",
]
@@ -2432,6 +2443,7 @@
depfile = "$target_gen_dir/$target_name.d"
outputs = [
+ depfile,
zip_path,
srcjar_path,
r_text_path,
@@ -2633,6 +2645,7 @@
script = "//build/android/gyp/generate_split_manifest.py"
outputs = [
+ depfile,
invoker.out_manifest,
]
inputs = [
« no previous file with comments | « android_webview/BUILD.gn ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698