//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599
Committed: https://crrev.com/96fd0c0feeb2745b724778f6de5f869276b7ef05
Cr-Commit-Position: refs/heads/master@{#418237}

[vabr (Chromium), 2016-09-07 10:28:42]

Description was changed from

==========
//chrome/browser/ A-L: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

to

==========
//chrome/browser and //components A-L: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

[vabr (Chromium), 2016-09-07 10:46:01]

Description was changed from

==========
//chrome/browser and //components A-L: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

to

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

[vabr (Chromium), 2016-09-09 15:59:24]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 15:59:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 17:24:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 17:24:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-09-09 18:01:55]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 18:02:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:28:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 21:28:53]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-09-12 08:23:11]

vabr@chromium.org changed reviewers:
+ asanka@chromium.org, jochen@chromium.org

[vabr (Chromium), 2016-09-12 08:23:12]

Hi asanka@ and jochen@!

asanka@ -- please review chrome/browser/download; the only non-mechanical change
is marked with a comment

jochen@ -- please rubber-stamp the rest; it is just renaming path() to
GetPath(); I will TBR you

Cheers,
Vaclav

https://codereview.chromium.org/2317993003/diff/140001/chrome/browser/downloa...
File chrome/browser/download/notification/download_notification_browsertest.cc
(right):

https://codereview.chromium.org/2317993003/diff/140001/chrome/browser/downloa...
chrome/browser/download/notification/download_notification_browsertest.cc:293:
// Must be called after browser creation. Assumes that |downloads_directory_|
To get rid of the need to check whether the directory was already created, I
separated the actions of creating the ScopedTempDir and of registering the paths
with the browser.

[vabr (Chromium), 2016-09-12 08:23:39]

Description was changed from

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

BUG=640599
==========

to

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599
==========

[jochen (gone - plz use gerrit), 2016-09-12 09:58:13]

lgtm

[asanka, 2016-09-12 13:56:13]

lgtm

[vabr (Chromium), 2016-09-13 13:45:22]

The CQ bit was checked by vabr@chromium.org

[vabr (Chromium), 2016-09-13 13:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2317993003/#ps160001
(title: "Just rebased")

[commit-bot: I haz the power, 2016-09-13 13:45:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 14:21:47]

Description was changed from

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599
==========

to

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599
==========

[commit-bot: I haz the power, 2016-09-13 14:21:49]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-09-13 14:24:01]

Description was changed from

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599
==========

to

==========
//chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

path() is being deprecated, GetPath() has better checking against wrong use.

For more context, see https://codereview.chromium.org/2275553005/.

TBR=jochen@chromium.org
R=asanka@chromium.org
BUG=640599

Committed: https://crrev.com/96fd0c0feeb2745b724778f6de5f869276b7ef05
Cr-Commit-Position: refs/heads/master@{#418237}
==========

[commit-bot: I haz the power, 2016-09-13 14:24:03]

Patchset 9 (id:??) landed as
https://crrev.com/96fd0c0feeb2745b724778f6de5f869276b7ef05
Cr-Commit-Position: refs/heads/master@{#418237}