chrome/browser/chrome_process_singleton_win_unittest.cc - Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_process_singleton_win_unittest.cc

Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Just rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover_browsertest.cc ('k') | chrome/browser/chrome_service_worker_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_process_singleton_win_unittest.cc

diff --git a/chrome/browser/chrome_process_singleton_win_unittest.cc b/chrome/browser/chrome_process_singleton_win_unittest.cc

index 26f06f3033c9de9ebca7bab6111ca247c20c772f..7bc4f71b2cbd76e881f9322b0cae1eec81a9fa2d 100644

--- a/chrome/browser/chrome_process_singleton_win_unittest.cc

+++ b/chrome/browser/chrome_process_singleton_win_unittest.cc

@@ -36,11 +36,12 @@ TEST(ChromeProcessSingletonTest, Basic) {

int callback_count = 0;

ChromeProcessSingleton ps1(

- profile_dir.path(),

+ profile_dir.GetPath(),

base::Bind(&ServerCallback, base::Unretained(&callback_count)));

ps1.Unlock();

- ChromeProcessSingleton ps2(profile_dir.path(), base::Bind(&ClientCallback));

+ ChromeProcessSingleton ps2(profile_dir.GetPath(),

+ base::Bind(&ClientCallback));

ps2.Unlock();

ProcessSingleton::NotifyResult result = ps1.NotifyOtherProcessOrCreate();

@@ -61,10 +62,11 @@ TEST(ChromeProcessSingletonTest, Lock) {

int callback_count = 0;

ChromeProcessSingleton ps1(

- profile_dir.path(),

+ profile_dir.GetPath(),

base::Bind(&ServerCallback, base::Unretained(&callback_count)));

- ChromeProcessSingleton ps2(profile_dir.path(), base::Bind(&ClientCallback));

+ ChromeProcessSingleton ps2(profile_dir.GetPath(),

+ base::Bind(&ClientCallback));

ps2.Unlock();

ProcessSingleton::NotifyResult result = ps1.NotifyOtherProcessOrCreate();

@@ -98,13 +100,14 @@ TEST(ChromeProcessSingletonTest, LockWithModalDialog) {

bool called_set_foreground_window = false;

ChromeProcessSingleton ps1(

- profile_dir.path(),

+ profile_dir.GetPath(),

base::Bind(&ServerCallback, base::Unretained(&callback_count)),

base::Bind(&SetForegroundWindowHandler,

base::Unretained(&called_set_foreground_window)));

ps1.SetActiveModalDialog(::GetShellWindow());

- ChromeProcessSingleton ps2(profile_dir.path(), base::Bind(&ClientCallback));

+ ChromeProcessSingleton ps2(profile_dir.GetPath(),

+ base::Bind(&ClientCallback));

ps2.Unlock();

ProcessSingleton::NotifyResult result = ps1.NotifyOtherProcessOrCreate();