Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Just rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_browsertest.cc
diff --git a/chrome/browser/download/download_browsertest.cc b/chrome/browser/download/download_browsertest.cc
index 8c22b417439b231cb3c8299cba5af45014693b29..a6962a3b39d3019b45d3dc44b90393892f0f9881 100644
--- a/chrome/browser/download/download_browsertest.cc
+++ b/chrome/browser/download/download_browsertest.cc
@@ -478,7 +478,7 @@ class DownloadTest : public InProcessBrowserTest {
}
base::FilePath GetDownloadsDirectory() {
- return downloads_directory_.path();
+ return downloads_directory_.GetPath();
}
// Location of the file source (the place from which it is downloaded).
@@ -503,11 +503,9 @@ class DownloadTest : public InProcessBrowserTest {
return false;
browser->profile()->GetPrefs()->SetFilePath(
- prefs::kDownloadDefaultDirectory,
- downloads_directory_.path());
+ prefs::kDownloadDefaultDirectory, downloads_directory_.GetPath());
browser->profile()->GetPrefs()->SetFilePath(
- prefs::kSaveFileDefaultDirectory,
- downloads_directory_.path());
+ prefs::kSaveFileDefaultDirectory, downloads_directory_.GetPath());
return true;
}
@@ -744,7 +742,7 @@ class DownloadTest : public InProcessBrowserTest {
base::FilePath basefilename(filename.BaseName());
net::FileURLToFilePath(url, &filename);
base::FilePath download_path =
- downloads_directory_.path().Append(basefilename);
+ downloads_directory_.GetPath().Append(basefilename);
bool downloaded_path_exists = base::PathExists(download_path);
EXPECT_TRUE(downloaded_path_exists);
@@ -2158,8 +2156,8 @@ IN_PROC_BROWSER_TEST_F(DownloadTest, DownloadUrlToPath) {
base::FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
base::ScopedTempDir other_directory;
ASSERT_TRUE(other_directory.CreateUniqueTempDir());
- base::FilePath target_file_full_path
- = other_directory.path().Append(file.BaseName());
+ base::FilePath target_file_full_path =
+ other_directory.GetPath().Append(file.BaseName());
content::DownloadTestObserver* observer(CreateWaiter(browser(), 1));
std::unique_ptr<DownloadUrlParameters> params(
DownloadUrlParameters::CreateForWebContentsMainFrame(

Powered by Google App Engine
This is Rietveld 408576698