Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3946)

Unified Diff: chrome/browser/apps/guest_view/web_view_browsertest.cc

Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath() (Closed)
Patch Set: Just rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/guest_view/web_view_browsertest.cc
diff --git a/chrome/browser/apps/guest_view/web_view_browsertest.cc b/chrome/browser/apps/guest_view/web_view_browsertest.cc
index fb189498276fc3b2f48b06eda479c326a4756d89..5233951e59ecae1cf8db2df7a252e0be383a493e 100644
--- a/chrome/browser/apps/guest_view/web_view_browsertest.cc
+++ b/chrome/browser/apps/guest_view/web_view_browsertest.cc
@@ -2452,7 +2452,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadPermission) {
base::ScopedTempDir temporary_download_dir;
ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());
DownloadPrefs::FromBrowserContext(guest_web_contents->GetBrowserContext())
- ->SetDownloadPath(temporary_download_dir.path());
+ ->SetDownloadPath(temporary_download_dir.GetPath());
std::unique_ptr<content::DownloadTestObserver> completion_observer(
new content::DownloadTestObserverTerminal(
@@ -2609,7 +2609,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadCookieIsolation) {
base::ScopedTempDir temporary_download_dir;
ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());
DownloadPrefs::FromBrowserContext(web_contents->GetBrowserContext())
- ->SetDownloadPath(temporary_download_dir.path());
+ ->SetDownloadPath(temporary_download_dir.GetPath());
content::DownloadManager* download_manager =
content::BrowserContext::GetDownloadManager(
@@ -2694,7 +2694,7 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, PRE_DownloadCookieIsolation_CrossSession) {
base::ScopedTempDir temporary_download_dir;
ASSERT_TRUE(temporary_download_dir.CreateUniqueTempDir());
DownloadPrefs::FromBrowserContext(web_contents->GetBrowserContext())
- ->SetDownloadPath(temporary_download_dir.path());
+ ->SetDownloadPath(temporary_download_dir.GetPath());
content::DownloadManager* download_manager =
content::BrowserContext::GetDownloadManager(
@@ -2791,8 +2791,8 @@ IN_PROC_BROWSER_TEST_P(WebViewTest, DownloadCookieIsolation_CrossSession) {
for (auto* download : downloads) {
ASSERT_TRUE(download->CanResume());
- ASSERT_TRUE(
- temporary_download_dir.path().IsParent(download->GetTargetFilePath()));
+ ASSERT_TRUE(temporary_download_dir.GetPath().IsParent(
+ download->GetTargetFilePath()));
ASSERT_TRUE(download->GetFullPath().empty());
EXPECT_EQ(content::DOWNLOAD_INTERRUPT_REASON_SERVER_FAILED,
download->GetLastReason());
« no previous file with comments | « chrome/browser/apps/app_browsertest.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698