chrome/browser/component_updater/sth_set_component_installer_unittest.cc - Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/sth_set_component_installer_unittest.cc

Issue 2317993003: //chrome/browser and //components A-E: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Just rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_service_worker_browsertest.cc ('k') | chrome/browser/component_updater/subresource_filter_component_installer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/sth_set_component_installer_unittest.cc

diff --git a/chrome/browser/component_updater/sth_set_component_installer_unittest.cc b/chrome/browser/component_updater/sth_set_component_installer_unittest.cc

index d965fc0ad2a246676d97b670daaea4c2d70869e4..4ab1c10767f12b85d0d62a518e5d3b6f51200fc8 100644

--- a/chrome/browser/component_updater/sth_set_component_installer_unittest.cc

+++ b/chrome/browser/component_updater/sth_set_component_installer_unittest.cc

@@ -55,7 +55,7 @@ class STHSetComponentInstallerTest : public PlatformTest {

}

base::FilePath GetSTHsDir() {

- return temp_dir_.path()

+ return temp_dir_.GetPath()

.Append(FILE_PATH_LITERAL("_platform_specific"))

.Append(FILE_PATH_LITERAL("all"))

.Append(FILE_PATH_LITERAL("sths"));

@@ -63,13 +63,13 @@ class STHSetComponentInstallerTest : public PlatformTest {

void CreateSTHsDir(const base::DictionaryValue& manifest,

const base::FilePath& sths_dir) {

- ASSERT_FALSE(traits_->VerifyInstallation(manifest, temp_dir_.path()));

+ ASSERT_FALSE(traits_->VerifyInstallation(manifest, temp_dir_.GetPath()));

ASSERT_TRUE(base::CreateDirectory(sths_dir));

}

void LoadSTHs(const base::DictionaryValue& manifest,

const base::FilePath& sths_dir) {

- ASSERT_TRUE(traits_->VerifyInstallation(manifest, temp_dir_.path()));

+ ASSERT_TRUE(traits_->VerifyInstallation(manifest, temp_dir_.GetPath()));

const base::Version v("1.0");

traits_->LoadSTHsFromDisk(sths_dir, v);