Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage (SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
Committed: https://crrev.com/260a8f74a7f1230c3252f2640ce7185981d8aef4
Cr-Commit-Position: refs/heads/master@{#417162}

[loyso (OOO), 2016-09-05 06:09:55]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:09:55]

loyso@chromium.org changed reviewers:
+ enne@chromium.org

[loyso (OOO), 2016-09-05 06:14:55]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 06:15:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[loyso (OOO), 2016-09-05 06:20:48]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail on frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message so the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:21:07]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail on frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message so the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail on frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:21:40]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail on frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:22:18]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened then
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened during that frame
THEN
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:24:40]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened during that frame
THEN
QueueMessageSwapPromise::DidNotSwap wouldn't send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message
so the callback inserted with RenderFrameHostImpl::InsertVisualStateCallback
never triggers.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

[loyso (OOO), 2016-09-05 06:25:30]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

If FrameSwapMessageQueue::DidActivate happened during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

[commit-bot: I haz the power, 2016-09-05 06:44:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 06:44:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[loyso (OOO), 2016-09-05 07:20:03]

The CQ bit was checked by loyso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 07:20:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 08:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 08:04:44]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2016-09-06 18:10:07]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

[enne (OOO), 2016-09-06 18:16:27]

enne@chromium.org changed reviewers:
+ jbauman@chromium.org, piman@chromium.org

[enne (OOO), 2016-09-06 18:17:16]

enne@chromium.org changed reviewers:
- jbauman@chromium.org

[enne (OOO), 2016-09-06 18:17:49]

I'm happy to review this if needed, but am going to defer to piman who reviewed
the original frame swap message queue.

[loyso (OOO), 2016-09-07 23:51:11]

piman@, PTAL?

[piman, 2016-09-08 00:52:33]

lgtm

[loyso (OOO), 2016-09-08 00:57:41]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:57:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 02:07:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-08 02:10:01]

Description was changed from

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484
==========

to

==========
Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap.

LayerTreeHostImpl::SwapBuffers may fail if frame.has_no_damage
(SwapPromise::SWAP_FAILS).

IF FrameSwapMessageQueue::DidActivate happens during that frame
THEN
the outputSurface will NOT take care of the Drain+Send.
AND
QueueMessageSwapPromise::DidNotSwap will not send the
MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE message back.

As a result, the callback inserted with
RenderFrameHostImpl::InsertVisualStateCallback never triggers.
PluginPowerSaverBrowserTest::VerifySnapshot hangs forever.

BUG=599484

Committed: https://crrev.com/260a8f74a7f1230c3252f2640ce7185981d8aef4
Cr-Commit-Position: refs/heads/master@{#417162}
==========

[commit-bot: I haz the power, 2016-09-08 02:10:02]

Patchset 3 (id:??) landed as
https://crrev.com/260a8f74a7f1230c3252f2640ce7185981d8aef4
Cr-Commit-Position: refs/heads/master@{#417162}