Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: content/renderer/gpu/queue_message_swap_promise_unittest.cc

Issue 2313593002: Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap. (Closed)
Patch Set: Fix QueueMessageSwapPromiseTest.VisualStateSwapPromiseDidActivate Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/queue_message_swap_promise.h" 5 #include "content/renderer/gpu/queue_message_swap_promise.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 std::vector<std::unique_ptr<IPC::Message>> messages; 259 std::vector<std::unique_ptr<IPC::Message>> messages;
260 messages.swap(NextSwapMessages()); 260 messages.swap(NextSwapMessages());
261 EXPECT_EQ(2u, messages.size()); 261 EXPECT_EQ(2u, messages.size());
262 EXPECT_TRUE(ContainsMessage(messages, messages_[0])); 262 EXPECT_TRUE(ContainsMessage(messages, messages_[0]));
263 EXPECT_TRUE(ContainsMessage(messages, messages_[1])); 263 EXPECT_TRUE(ContainsMessage(messages, messages_[1]));
264 EXPECT_FALSE(ContainsMessage(messages, messages_[2])); 264 EXPECT_FALSE(ContainsMessage(messages, messages_[2]));
265 265
266 promises_[2]->DidActivate(); 266 promises_[2]->DidActivate();
267 promises_[2]->DidNotSwap(cc::SwapPromise::SWAP_FAILS); 267 promises_[2]->DidNotSwap(cc::SwapPromise::SWAP_FAILS);
268 messages.swap(NextSwapMessages()); 268 messages.swap(NextSwapMessages());
269 EXPECT_EQ(1u, messages.size()); 269 EXPECT_TRUE(messages.empty());
270 EXPECT_TRUE(ContainsMessage(messages, messages_[2]));
271 270
272 EXPECT_TRUE(DirectSendMessages().empty()); 271 EXPECT_EQ(1u, DirectSendMessages().size());
272 EXPECT_TRUE(ContainsMessage(DirectSendMessages(), messages_[2]));
273
273 EXPECT_TRUE(NextSwapMessages().empty()); 274 EXPECT_TRUE(NextSwapMessages().empty());
274 EXPECT_TRUE(frame_swap_message_queue_->Empty()); 275 EXPECT_TRUE(frame_swap_message_queue_->Empty());
275 } 276 }
276 277
277 void QueueMessageSwapPromiseTest::VisualStateSwapPromiseDidNotSwap( 278 void QueueMessageSwapPromiseTest::VisualStateSwapPromiseDidNotSwap(
278 cc::SwapPromise::DidNotSwapReason reason) { 279 cc::SwapPromise::DidNotSwapReason reason) {
279 QueueMessageData data[] = { 280 QueueMessageData data[] = {
280 /* { policy, source_frame_number } */ 281 /* { policy, source_frame_number } */
281 {MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE, 1}, 282 {MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE, 1},
282 {MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE, 1}, 283 {MESSAGE_DELIVERY_POLICY_WITH_VISUAL_STATE, 1},
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
317 TEST_F(QueueMessageSwapPromiseTest, VisualStateSwapPromiseDidNotSwapSwapFails) { 318 TEST_F(QueueMessageSwapPromiseTest, VisualStateSwapPromiseDidNotSwapSwapFails) {
318 VisualStateSwapPromiseDidNotSwap(cc::SwapPromise::SWAP_FAILS); 319 VisualStateSwapPromiseDidNotSwap(cc::SwapPromise::SWAP_FAILS);
319 } 320 }
320 321
321 TEST_F(QueueMessageSwapPromiseTest, 322 TEST_F(QueueMessageSwapPromiseTest,
322 VisualStateSwapPromiseDidNotSwapActivationFails) { 323 VisualStateSwapPromiseDidNotSwapActivationFails) {
323 VisualStateSwapPromiseDidNotSwap(cc::SwapPromise::ACTIVATION_FAILS); 324 VisualStateSwapPromiseDidNotSwap(cc::SwapPromise::ACTIVATION_FAILS);
324 } 325 }
325 326
326 } // namespace content 327 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698