Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 2313593002: Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap. (Closed)
Patch Set: Fix QueueMessageSwapPromiseTest.VisualStateSwapPromiseDidActivate Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/frame_swap_message_queue_unittest.cc
diff --git a/content/renderer/gpu/frame_swap_message_queue_unittest.cc b/content/renderer/gpu/frame_swap_message_queue_unittest.cc
index 8488b559b55c4a849ee2d8d3dc4b837a36d6e5c3..54e4f7de4a6a1c3fd21cb34fbc73ee6d5b533b6b 100644
--- a/content/renderer/gpu/frame_swap_message_queue_unittest.cc
+++ b/content/renderer/gpu/frame_swap_message_queue_unittest.cc
@@ -288,4 +288,21 @@ TEST_F(FrameSwapMessageQueueTest, TestDeletesQueuedVisualStateMessage) {
ASSERT_TRUE(message_deleted);
}
+TEST_F(FrameSwapMessageQueueTest, TestDrainsMessageOnActivationThanDidNotSwap) {
+ const int frame = 6;
+ std::unique_ptr<IPC::Message> msg = CloneMessage(first_message_);
+ IPC::Message* msgSent = msg.get();
+ QueueVisualStateMessage(frame, std::move(msg));
+ queue_->DidActivate(frame);
+ EXPECT_TRUE(!queue_->Empty());
+
+ std::vector<std::unique_ptr<IPC::Message>> messages;
+ queue_->DidNotSwap(frame, cc::SwapPromise::SWAP_FAILS, &messages);
+ CHECK_EQ(1UL, messages.size());
+ EXPECT_EQ(messages[0].get(), msgSent);
+ msgSent = nullptr;
+
+ queue_ = nullptr;
+}
+
} // namespace content
« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue.cc ('k') | content/renderer/gpu/queue_message_swap_promise_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698