Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 2313593002: Content Renderer FrameSwapMessageQueue: Fix DidActivate with DidNotSwap. (Closed)
Patch Set: Fix QueueMessageSwapPromiseTest.VisualStateSwapPromiseDidActivate Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/gpu/frame_swap_message_queue.h" 5 #include "content/renderer/gpu/frame_swap_message_queue.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "ipc/ipc_message.h" 10 #include "ipc/ipc_message.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 TEST_F(FrameSwapMessageQueueTest, TestDeletesQueuedVisualStateMessage) { 281 TEST_F(FrameSwapMessageQueueTest, TestDeletesQueuedVisualStateMessage) {
282 bool message_deleted = false; 282 bool message_deleted = false;
283 QueueVisualStateMessage(1, base::MakeUnique<NotifiesDeletionMessage>( 283 QueueVisualStateMessage(1, base::MakeUnique<NotifiesDeletionMessage>(
284 &message_deleted, first_message_)); 284 &message_deleted, first_message_));
285 queue_->DidActivate(1); 285 queue_->DidActivate(1);
286 queue_->DidSwap(1); 286 queue_->DidSwap(1);
287 queue_ = NULL; 287 queue_ = NULL;
288 ASSERT_TRUE(message_deleted); 288 ASSERT_TRUE(message_deleted);
289 } 289 }
290 290
291 TEST_F(FrameSwapMessageQueueTest, TestDrainsMessageOnActivationThanDidNotSwap) {
292 const int frame = 6;
293 std::unique_ptr<IPC::Message> msg = CloneMessage(first_message_);
294 IPC::Message* msgSent = msg.get();
295 QueueVisualStateMessage(frame, std::move(msg));
296 queue_->DidActivate(frame);
297 EXPECT_TRUE(!queue_->Empty());
298
299 std::vector<std::unique_ptr<IPC::Message>> messages;
300 queue_->DidNotSwap(frame, cc::SwapPromise::SWAP_FAILS, &messages);
301 CHECK_EQ(1UL, messages.size());
302 EXPECT_EQ(messages[0].get(), msgSent);
303 msgSent = nullptr;
304
305 queue_ = nullptr;
306 }
307
291 } // namespace content 308 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue.cc ('k') | content/renderer/gpu/queue_message_swap_promise_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698