Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2313133002: Fix crashers and issues when rendering blimp in tabs (Closed)

Created:
4 years, 3 months ago by nyquist
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crashers and issues when rendering blimp in tabs - Remove the limitation where size messages was never re-sent if the values did not change. However, when creating new BlimpContents, we need to re-send the size to get the engine to know the correct size. - Do a graceful bail out for when BlimpContents are not created. This is required when there already is a BlimpContents created, but not yet destroyed. This makes WebContents-based and BlimpContents based tabs seamless. - Messages from the engine might arrive after a BlimpContents has been deleted, so those messages should be ignored. BUG=644440 Committed: https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061 Cr-Commit-Position: refs/heads/master@{#416880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M blimp/client/core/contents/blimp_navigation_controller_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download
M blimp/client/core/contents/tab_control_feature.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M blimp/client/core/contents/tab_control_feature_unittest.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M blimp/client/core/render_widget/render_widget_feature.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
nyquist
dtrainor: PTAL
4 years, 3 months ago (2016-09-06 23:04:39 UTC) #5
David Trainor- moved to gerrit
lgtm
4 years, 3 months ago (2016-09-07 05:10:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313133002/1
4 years, 3 months ago (2016-09-07 08:03:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 08:07:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 08:08:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9189c7232659395664e5fc99c62853abd9ffa061
Cr-Commit-Position: refs/heads/master@{#416880}

Powered by Google App Engine
This is Rietveld 408576698