Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3339)

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl.cc

Issue 2313133002: Fix crashers and issues when rendering blimp in tabs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/client/core/contents/tab_control_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/contents/blimp_navigation_controller_impl.cc
diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl.cc b/blimp/client/core/contents/blimp_navigation_controller_impl.cc
index 7461e5db833b73c9d907507e30cf0f520928acc0..bd18ddd63deffd7130ed7aafa28d8b7355aaef05 100644
--- a/blimp/client/core/contents/blimp_navigation_controller_impl.cc
+++ b/blimp/client/core/contents/blimp_navigation_controller_impl.cc
@@ -23,7 +23,10 @@ BlimpNavigationControllerImpl::BlimpNavigationControllerImpl(
navigation_feature_->SetDelegate(kDummyTabId, this);
}
-BlimpNavigationControllerImpl::~BlimpNavigationControllerImpl() = default;
+BlimpNavigationControllerImpl::~BlimpNavigationControllerImpl() {
+ if (navigation_feature_)
+ navigation_feature_->RemoveDelegate(kDummyTabId);
+}
void BlimpNavigationControllerImpl::LoadURL(const GURL& url) {
current_url_ = url;
« no previous file with comments | « no previous file | blimp/client/core/contents/tab_control_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698