Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: blimp/client/core/render_widget/render_widget_feature.cc

Issue 2313133002: Fix crashers and issues when rendering blimp in tabs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/core/contents/tab_control_feature_unittest.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/core/render_widget/render_widget_feature.cc
diff --git a/blimp/client/core/render_widget/render_widget_feature.cc b/blimp/client/core/render_widget/render_widget_feature.cc
index e34706ada7877d39de616eb4eca15c711c1fd45b..f84e75e9635ae0d546d500acaef542b29849180e 100644
--- a/blimp/client/core/render_widget/render_widget_feature.cc
+++ b/blimp/client/core/render_widget/render_widget_feature.cc
@@ -88,8 +88,12 @@ void RenderWidgetFeature::ProcessMessage(
int target_tab_id = message->target_tab_id();
RenderWidgetFeatureDelegate* delegate = FindDelegate(target_tab_id);
- DCHECK(delegate) << "RenderWidgetFeatureDelegate not found for "
- << target_tab_id;
+ if (!delegate) {
+ VLOG(1) << "RenderWidgetFeatureDelegate not found for " << target_tab_id
+ << ". Ignoring.";
+ callback.Run(net::OK);
+ return;
+ }
switch (message->feature_case()) {
case BlimpMessage::kRenderWidget:
« no previous file with comments | « blimp/client/core/contents/tab_control_feature_unittest.cc ('k') | chrome/browser/android/tab_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698