Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: blimp/client/core/contents/tab_control_feature_unittest.cc

Issue 2313133002: Fix crashers and issues when rendering blimp in tabs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/tab_control_feature_unittest.cc
diff --git a/blimp/client/core/contents/tab_control_feature_unittest.cc b/blimp/client/core/contents/tab_control_feature_unittest.cc
index 69acd60fe0668f69cfc3d34ad4e426a9174877e1..7a240552f0d91a74a913f625b8b51945a773ef35 100644
--- a/blimp/client/core/contents/tab_control_feature_unittest.cc
+++ b/blimp/client/core/contents/tab_control_feature_unittest.cc
@@ -56,7 +56,7 @@ TEST_F(TabControlFeatureTest, CreatesCorrectSizeMessage) {
feature_.SetSizeAndScale(gfx::Size(width, height), dp_to_px);
}
-TEST_F(TabControlFeatureTest, NoDuplicateSizeMessage) {
+TEST_F(TabControlFeatureTest, EnsureDuplicateSizeMessageAllowed) {
uint64_t width = 10;
uint64_t height = 15;
float dp_to_px = 1.23f;
@@ -64,29 +64,32 @@ TEST_F(TabControlFeatureTest, NoDuplicateSizeMessage) {
EXPECT_CALL(
*out_processor_,
MockableProcessMessage(EqualsSizeMessage(width, height, dp_to_px), _))
- .Times(1)
+ .Times(2)
.RetiresOnSaturation();
EXPECT_CALL(
*out_processor_,
MockableProcessMessage(EqualsSizeMessage(width, height, dp_to_px + 1), _))
- .Times(1)
+ .Times(2)
.RetiresOnSaturation();
EXPECT_CALL(*out_processor_,
MockableProcessMessage(
EqualsSizeMessage(width + 1, height, dp_to_px + 1), _))
- .Times(1)
+ .Times(2)
.RetiresOnSaturation();
EXPECT_CALL(*out_processor_,
MockableProcessMessage(
EqualsSizeMessage(width + 1, height + 1, dp_to_px + 1), _))
- .Times(1)
+ .Times(2)
.RetiresOnSaturation();
feature_.SetSizeAndScale(gfx::Size(width, height), dp_to_px);
feature_.SetSizeAndScale(gfx::Size(width, height), dp_to_px);
feature_.SetSizeAndScale(gfx::Size(width, height), dp_to_px + 1);
+ feature_.SetSizeAndScale(gfx::Size(width, height), dp_to_px + 1);
+ feature_.SetSizeAndScale(gfx::Size(width + 1, height), dp_to_px + 1);
feature_.SetSizeAndScale(gfx::Size(width + 1, height), dp_to_px + 1);
feature_.SetSizeAndScale(gfx::Size(width + 1, height + 1), dp_to_px + 1);
+ feature_.SetSizeAndScale(gfx::Size(width + 1, height + 1), dp_to_px + 1);
}
} // namespace client
« no previous file with comments | « blimp/client/core/contents/tab_control_feature.cc ('k') | blimp/client/core/render_widget/render_widget_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698