Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: blimp/client/core/contents/tab_control_feature.cc

Issue 2313133002: Fix crashers and issues when rendering blimp in tabs (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/client/core/contents/tab_control_feature.h" 5 #include "blimp/client/core/contents/tab_control_feature.h"
6 6
7 #include "blimp/common/create_blimp_message.h" 7 #include "blimp/common/create_blimp_message.h"
8 #include "blimp/common/proto/blimp_message.pb.h" 8 #include "blimp/common/proto/blimp_message.pb.h"
9 #include "blimp/common/proto/tab_control.pb.h" 9 #include "blimp/common/proto/tab_control.pb.h"
10 #include "blimp/net/blimp_message_processor.h" 10 #include "blimp/net/blimp_message_processor.h"
11 #include "net/base/net_errors.h" 11 #include "net/base/net_errors.h"
12 12
13 namespace blimp { 13 namespace blimp {
14 namespace client { 14 namespace client {
15 15
16 TabControlFeature::TabControlFeature() {} 16 TabControlFeature::TabControlFeature() {}
17 17
18 TabControlFeature::~TabControlFeature() {} 18 TabControlFeature::~TabControlFeature() {}
19 19
20 void TabControlFeature::set_outgoing_message_processor( 20 void TabControlFeature::set_outgoing_message_processor(
21 std::unique_ptr<BlimpMessageProcessor> processor) { 21 std::unique_ptr<BlimpMessageProcessor> processor) {
22 outgoing_message_processor_ = std::move(processor); 22 outgoing_message_processor_ = std::move(processor);
23 } 23 }
24 24
25 void TabControlFeature::SetSizeAndScale(const gfx::Size& size, 25 void TabControlFeature::SetSizeAndScale(const gfx::Size& size,
26 float device_pixel_ratio) { 26 float device_pixel_ratio) {
27 if (last_size_ == size && last_device_pixel_ratio_ == device_pixel_ratio) {
28 return;
29 }
30
31 last_size_ = size; 27 last_size_ = size;
32 last_device_pixel_ratio_ = device_pixel_ratio; 28 last_device_pixel_ratio_ = device_pixel_ratio;
33 29
34 SizeMessage* size_details; 30 SizeMessage* size_details;
35 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&size_details); 31 std::unique_ptr<BlimpMessage> message = CreateBlimpMessage(&size_details);
36 size_details->set_width(size.width()); 32 size_details->set_width(size.width());
37 size_details->set_height(size.height()); 33 size_details->set_height(size.height());
38 size_details->set_device_pixel_ratio(device_pixel_ratio); 34 size_details->set_device_pixel_ratio(device_pixel_ratio);
39 35
40 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a 36 // TODO(dtrainor): Don't keep sending size events to the server. Wait for a
(...skipping 22 matching lines...) Expand all
63 std::unique_ptr<BlimpMessage> message, 59 std::unique_ptr<BlimpMessage> message,
64 const net::CompletionCallback& callback) { 60 const net::CompletionCallback& callback) {
65 DCHECK(!callback.is_null()); 61 DCHECK(!callback.is_null());
66 callback.Run(net::OK); 62 callback.Run(net::OK);
67 63
68 NOTIMPLEMENTED(); 64 NOTIMPLEMENTED();
69 } 65 }
70 66
71 } // namespace client 67 } // namespace client
72 } // namespace blimp 68 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698