Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2303953002: Rename an Enum to a slightly better name. (Closed)

Created:
4 years, 3 months ago by Pete Williamson
Modified:
4 years, 3 months ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename an Enum to a slightly better name. Resolves an outstanding TODO to choose a better name for this enum. BUG=610521 Committed: https://crrev.com/4ec7530c52fae61b0468721a427c5a80afb20b0f Cr-Commit-Position: refs/heads/master@{#416684}

Patch Set 1 #

Patch Set 2 : Merged. #

Messages

Total messages: 13 (6 generated)
Pete Williamson
As you requested in your (post commit) code review.
4 years, 3 months ago (2016-09-01 22:25:41 UTC) #2
dougarnett
lgtm
4 years, 3 months ago (2016-09-02 00:43:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303953002/1
4 years, 3 months ago (2016-09-06 16:48:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/263615) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-06 16:50:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303953002/20001
4 years, 3 months ago (2016-09-06 18:00:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 18:50:57 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:54:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ec7530c52fae61b0468721a427c5a80afb20b0f
Cr-Commit-Position: refs/heads/master@{#416684}

Powered by Google App Engine
This is Rietveld 408576698