Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: components/offline_pages/background/request_notifier.h

Issue 2303953002: Rename an Enum to a slightly better name. (Closed)
Patch Set: Merged. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_ 5 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_
6 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_ 6 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_
7 7
8 namespace offline_pages { 8 namespace offline_pages {
9 9
10 class SavePageRequest; 10 class SavePageRequest;
11 11
12 class RequestNotifier { 12 class RequestNotifier {
13 public: 13 public:
14 // Status to return for failed notifications. 14 // Status to return for failed notifications.
15 // TODO(petewil): Can we find a better name for this enum? 15 enum class BackgroundSavePageResult {
16 enum class SavePageStatus {
17 SUCCESS, 16 SUCCESS,
18 PRERENDER_FAILURE, 17 PRERENDER_FAILURE,
19 PRERENDER_CANCELED, 18 PRERENDER_CANCELED,
20 FOREGROUND_CANCELED, 19 FOREGROUND_CANCELED,
21 SAVE_FAILED, 20 SAVE_FAILED,
22 EXPIRED, 21 EXPIRED,
23 RETRY_COUNT_EXCEEDED, 22 RETRY_COUNT_EXCEEDED,
24 START_COUNT_EXCEEDED, 23 START_COUNT_EXCEEDED,
25 REMOVED, 24 REMOVED,
26 }; 25 };
27 26
28 virtual ~RequestNotifier() = default; 27 virtual ~RequestNotifier() = default;
29 28
30 // Notifies observers that |request| has been added. 29 // Notifies observers that |request| has been added.
31 virtual void NotifyAdded(const SavePageRequest& request) = 0; 30 virtual void NotifyAdded(const SavePageRequest& request) = 0;
32 31
33 // Notifies observers that |request| has been completed with |status|. 32 // Notifies observers that |request| has been completed with |status|.
34 virtual void NotifyCompleted(const SavePageRequest& request, 33 virtual void NotifyCompleted(const SavePageRequest& request,
35 SavePageStatus status) = 0; 34 BackgroundSavePageResult status) = 0;
36 35
37 // Notifies observers that |request| has been changed. 36 // Notifies observers that |request| has been changed.
38 virtual void NotifyChanged(const SavePageRequest& request) = 0; 37 virtual void NotifyChanged(const SavePageRequest& request) = 0;
39 }; 38 };
40 39
41 } // namespace offline_pages 40 } // namespace offline_pages
42 41
43 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_ 42 #endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REQUEST_NOTIFIER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698