Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: components/offline_pages/downloads/download_notifying_observer_unittest.cc

Issue 2303953002: Rename an Enum to a slightly better name. (Closed)
Patch Set: Merged. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/downloads/download_notifying_observer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/downloads/download_notifying_observer_unittest.cc
diff --git a/components/offline_pages/downloads/download_notifying_observer_unittest.cc b/components/offline_pages/downloads/download_notifying_observer_unittest.cc
index bd49c3efaa4f4c9b899db08fe87c0f93055868a4..d28759984ad7973a52e2b79dfbb6740736fe9362 100644
--- a/components/offline_pages/downloads/download_notifying_observer_unittest.cc
+++ b/components/offline_pages/downloads/download_notifying_observer_unittest.cc
@@ -162,7 +162,8 @@ TEST_F(DownloadNotifyingObserverTest, OnChangedToAvailable) {
TEST_F(DownloadNotifyingObserverTest, OnCompletedSuccess) {
SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
kTestCreationTime, kTestUserRequested);
- observer()->OnCompleted(request, RequestNotifier::SavePageStatus::SUCCESS);
+ observer()->OnCompleted(request,
+ RequestNotifier::BackgroundSavePageResult::SUCCESS);
EXPECT_EQ(LastNotificationType::DOWNLOAD_SUCCESSFUL,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -173,7 +174,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedSuccess) {
TEST_F(DownloadNotifyingObserverTest, OnCompletedCanceled) {
SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
kTestCreationTime, kTestUserRequested);
- observer()->OnCompleted(request, RequestNotifier::SavePageStatus::REMOVED);
+ observer()->OnCompleted(request,
+ RequestNotifier::BackgroundSavePageResult::REMOVED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_CANCELED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -184,8 +186,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedCanceled) {
TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
SavePageRequest request(kTestOfflineId, GURL(kTestUrl), kTestClientId,
kTestCreationTime, kTestUserRequested);
- observer()->OnCompleted(request,
- RequestNotifier::SavePageStatus::PRERENDER_FAILURE);
+ observer()->OnCompleted(
+ request, RequestNotifier::BackgroundSavePageResult::PRERENDER_FAILURE);
EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -193,8 +195,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
notifier()->Reset();
- observer()->OnCompleted(request,
- RequestNotifier::SavePageStatus::FOREGROUND_CANCELED);
+ observer()->OnCompleted(
+ request, RequestNotifier::BackgroundSavePageResult::FOREGROUND_CANCELED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -202,8 +204,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
notifier()->Reset();
- observer()->OnCompleted(request,
- RequestNotifier::SavePageStatus::SAVE_FAILED);
+ observer()->OnCompleted(
+ request, RequestNotifier::BackgroundSavePageResult::SAVE_FAILED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -211,7 +213,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
EXPECT_EQ(kTestCreationTime, notifier()->download_item()->start_time);
notifier()->Reset();
- observer()->OnCompleted(request, RequestNotifier::SavePageStatus::EXPIRED);
+ observer()->OnCompleted(request,
+ RequestNotifier::BackgroundSavePageResult::EXPIRED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
@@ -220,7 +223,7 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {
notifier()->Reset();
observer()->OnCompleted(
- request, RequestNotifier::SavePageStatus::RETRY_COUNT_EXCEEDED);
+ request, RequestNotifier::BackgroundSavePageResult::RETRY_COUNT_EXCEEDED);
EXPECT_EQ(LastNotificationType::DOWNLOAD_FAILED,
notifier()->last_notification_type());
EXPECT_EQ(kTestGuid, notifier()->download_item()->guid);
« no previous file with comments | « components/offline_pages/downloads/download_notifying_observer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698