Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/offline_pages/background/request_notifier.h

Issue 2303953002: Rename an Enum to a slightly better name. (Closed)
Patch Set: Merged. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_notifier.h
diff --git a/components/offline_pages/background/request_notifier.h b/components/offline_pages/background/request_notifier.h
index 00258588f37604312d970e2772cb50fc91ee591a..af74f273ddf1208ea04161a8f206c2c8bdd30a82 100644
--- a/components/offline_pages/background/request_notifier.h
+++ b/components/offline_pages/background/request_notifier.h
@@ -12,8 +12,7 @@ class SavePageRequest;
class RequestNotifier {
public:
// Status to return for failed notifications.
- // TODO(petewil): Can we find a better name for this enum?
- enum class SavePageStatus {
+ enum class BackgroundSavePageResult {
SUCCESS,
PRERENDER_FAILURE,
PRERENDER_CANCELED,
@@ -32,7 +31,7 @@ class RequestNotifier {
// Notifies observers that |request| has been completed with |status|.
virtual void NotifyCompleted(const SavePageRequest& request,
- SavePageStatus status) = 0;
+ BackgroundSavePageResult status) = 0;
// Notifies observers that |request| has been changed.
virtual void NotifyChanged(const SavePageRequest& request) = 0;

Powered by Google App Engine
This is Rietveld 408576698