Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: components/offline_pages/background/request_coordinator.h

Issue 2303953002: Rename an Enum to a slightly better name. (Closed)
Patch Set: Merged. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/request_coordinator.h
diff --git a/components/offline_pages/background/request_coordinator.h b/components/offline_pages/background/request_coordinator.h
index e5745896a658af0814843642fbf558e6fc770ea0..d80f521cdf6a98468b66b9cfe267ba9120f6cf2b 100644
--- a/components/offline_pages/background/request_coordinator.h
+++ b/components/offline_pages/background/request_coordinator.h
@@ -48,8 +48,9 @@ class RequestCoordinator : public KeyedService,
virtual ~Observer() = default;
virtual void OnAdded(const SavePageRequest& request) = 0;
- virtual void OnCompleted(const SavePageRequest& request,
- RequestNotifier::SavePageStatus status) = 0;
+ virtual void OnCompleted(
+ const SavePageRequest& request,
+ RequestNotifier::BackgroundSavePageResult status) = 0;
virtual void OnChanged(const SavePageRequest& request) = 0;
};
@@ -129,8 +130,9 @@ class RequestCoordinator : public KeyedService,
// Implement RequestNotifier
void NotifyAdded(const SavePageRequest& request) override;
- void NotifyCompleted(const SavePageRequest& request,
- RequestNotifier::SavePageStatus status) override;
+ void NotifyCompleted(
+ const SavePageRequest& request,
+ RequestNotifier::BackgroundSavePageResult status) override;
void NotifyChanged(const SavePageRequest& request) override;
// Returns the request queue used for requests. Coordinator keeps ownership.
@@ -187,12 +189,12 @@ class RequestCoordinator : public KeyedService,
void HandleRemovedRequestsAndCallback(
const RemoveRequestsCallback& callback,
- SavePageStatus status,
+ BackgroundSavePageResult status,
const RequestQueue::UpdateMultipleRequestResults& results,
const std::vector<SavePageRequest>& requests);
void HandleRemovedRequests(
- SavePageStatus status,
+ BackgroundSavePageResult status,
const RequestQueue::UpdateMultipleRequestResults& results,
const std::vector<SavePageRequest>& requests);
@@ -234,7 +236,7 @@ class RequestCoordinator : public KeyedService,
// Remove the attempted request from the queue with status to pass through to
// any observers and UMA histogram.
void RemoveAttemptedRequest(const SavePageRequest& request,
- SavePageStatus status);
+ BackgroundSavePageResult status);
// Returns the appropriate offliner to use, getting a new one from the factory
// if needed.
« no previous file with comments | « no previous file | components/offline_pages/background/request_coordinator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698