Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: include/core/SkColorSpace.h

Issue 2302413002: Delete SkColorSpace::kUnknown_Named, remove fNamed field (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Use a bare ptr instead of an sk_sp Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkColorSpace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkColorSpace.h
diff --git a/include/core/SkColorSpace.h b/include/core/SkColorSpace.h
index 4ab025655c565016696d30d8b7fc8f55d9e0e061..e0ef70eeca22a130a7782f17fc0f7956651942c1 100644
--- a/include/core/SkColorSpace.h
+++ b/include/core/SkColorSpace.h
@@ -19,13 +19,21 @@ public:
/**
* Common, named profiles that we can recognize.
*/
- enum Named {
- kUnknown_Named,
+ enum Named : uint8_t {
+ /**
+ * By far the most common color space.
+ * This is the default space for images, unmarked content, and monitors.
+ */
kSRGB_Named,
+
+ /**
+ * Very common wide gamut color space.
+ * Often used by images and monitors.
+ */
kAdobeRGB_Named,
};
- enum GammaNamed {
+ enum GammaNamed : uint8_t {
kLinear_GammaNamed,
/**
@@ -111,11 +119,10 @@ public:
static bool Equals(const SkColorSpace* src, const SkColorSpace* dst);
protected:
- SkColorSpace(GammaNamed gammaNamed, const SkMatrix44& toXYZD50, Named named);
+ SkColorSpace(GammaNamed gammaNamed, const SkMatrix44& toXYZD50);
const GammaNamed fGammaNamed;
const SkMatrix44 fToXYZD50;
- const Named fNamed;
};
#endif
« no previous file with comments | « no previous file | src/core/SkColorSpace.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698