Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2306313002: Revert of Delete SkColorSpace::kUnknown_Named, remove fNamed field (Closed)

Created:
4 years, 3 months ago by Matt Giuca
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Delete SkColorSpace::kUnknown_Named, remove fNamed field (patchset #1 id:20001 of https://codereview.chromium.org/2302413002/ ) Reason for revert: This CL introduced two static initializers (gAdobeRGB and gSRGB) which are causing a sizes regression on Chromium builders: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/24981 Original issue's description: > Delete SkColorSpace::kUnknown_Named, remove fNamed field > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302413002 > > Committed: https://skia.googlesource.com/skia/+/54682e856cb66c653bc7e253981a421a2618398e TBR=reed@google.com,brianosman@google.com,msarett@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia:5724 Committed: https://skia.googlesource.com/skia/+/008fbd1b8e8339797d0f43164acde6357edb9dc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -46 lines) Patch
M include/core/SkColorSpace.h View 2 chunks +5 lines, -12 lines 0 comments Download
M src/core/SkColorSpace.cpp View 12 chunks +46 lines, -30 lines 0 comments Download
M src/core/SkColorSpace_Base.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/ColorSpaceTest.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Matt Giuca
Created Revert of Delete SkColorSpace::kUnknown_Named, remove fNamed field
4 years, 3 months ago (2016-09-05 04:47:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306313002/1
4 years, 3 months ago (2016-09-05 04:48:57 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-09-05 04:48:58 UTC) #5
Matt Giuca
On 2016/09/05 04:48:58, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
4 years, 3 months ago (2016-09-05 06:48:57 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
4 years, 3 months ago (2016-09-05 10:48:59 UTC) #8
hal.canary
On 2016/09/05 10:48:59, commit-bot: I haz the power wrote: > No LGTM from a valid ...
4 years, 3 months ago (2016-09-05 11:57:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2306313002/1
4 years, 3 months ago (2016-09-05 11:58:02 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:58:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/008fbd1b8e8339797d0f43164acde6357edb9dc6

Powered by Google App Engine
This is Rietveld 408576698