DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways.

DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).

Committed: https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451
Cr-Commit-Position: refs/heads/master@{#417223}

[pfeldman, 2016-09-02 18:13:36]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2016-09-02 19:33:07]

Don't forget to create DevToolsManagerDelegate for AW and cast in
ContentBrowserClient.

lgtm

https://codereview.chromium.org/2300703005/diff/20001/android_webview/native/...
File android_webview/native/aw_dev_tools_server.cc (right):

https://codereview.chromium.org/2300703005/diff/20001/android_webview/native/...
android_webview/native/aw_dev_tools_server.cc:55: std::string
GetTargetType(RenderFrameHost* host) override;
Let's turn SetDescription into GetTargetDescription.

https://codereview.chromium.org/2300703005/diff/20001/content/browser/devtool...
File content/browser/devtools/devtools_manager.cc (right):

https://codereview.chromium.org/2300703005/diff/20001/content/browser/devtool...
content/browser/devtools/devtools_manager.cc:28:
manager->SetHttpHandler(base::WrapUnique(new DevToolsHttpHandler(
if (!delegate) return;

https://codereview.chromium.org/2300703005/diff/20001/content/public/browser/...
File content/public/browser/devtools_agent_host.h (right):

https://codereview.chromium.org/2300703005/diff/20001/content/public/browser/...
content/public/browser/devtools_agent_host.h:51: static DevToolsManagerDelegate*
GetDevToolsManagerDelegate();
Remove this one.

https://codereview.chromium.org/2300703005/diff/20001/content/shell/browser/s...
File content/shell/browser/shell_browser_main_parts.cc (right):

https://codereview.chromium.org/2300703005/diff/20001/content/shell/browser/s...
content/shell/browser/shell_browser_main_parts.cc:212:
DevToolsAgentHost::StopRemoteDebuggingServer();
Remove this.

[pfeldman, 2016-09-02 23:50:23]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 23:50:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 23:53:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 23:53:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-09-06 19:53:14]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 19:54:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 19:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 19:59:00]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-09-06 20:49:17]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 20:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 20:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 20:59:54]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-06 21:35:50]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 21:36:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 21:44:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 21:44:26]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-07 19:10:32]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 19:11:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-07 19:12:53]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-09-07 19:19:09]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[pfeldman, 2016-09-07 19:19:35]

The CQ bit was unchecked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:19:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-07 19:22:32]

Patchset #5 (id:80001) has been deleted

[pfeldman, 2016-09-07 19:22:42]

Patchset #5 (id:100001) has been deleted

[pfeldman, 2016-09-07 19:22:52]

Patchset #6 (id:140001) has been deleted

[pfeldman, 2016-09-07 19:23:00]

Patchset #6 (id:160001) has been deleted

[pfeldman, 2016-09-07 19:23:08]

Patchset #5 (id:120001) has been deleted

[pfeldman, 2016-09-07 19:23:17]

Patchset #4 (id:60001) has been deleted

[pfeldman, 2016-09-07 19:23:31]

Patchset #3 (id:40001) has been deleted

[pfeldman, 2016-09-07 21:48:08]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 21:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:52:53]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-09-07 21:55:12]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-09-07 22:03:49]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:04:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-07 22:05:31]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-09-07 22:16:52]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:17:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:26:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:26:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-07 22:47:07]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 22:47:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 22:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 22:51:59]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-09-07 23:21:59]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:33:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:33:32]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-09-07 23:37:40]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-07 23:37:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2300703005/#ps320001
(title: "for landing")

[commit-bot: I haz the power, 2016-09-07 23:38:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:43:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:43:35]

Exceeded global retry quota

[pfeldman, 2016-09-07 23:50:02]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 23:50:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 23:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 23:55:03]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-08 00:16:58]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 00:17:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 00:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 00:21:09]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-08 00:59:02]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 00:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 01:37:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 01:37:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-09-08 02:38:44]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 02:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-08 02:43:38]

Description was changed from

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
==========

to

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
==========

[pfeldman, 2016-09-08 02:55:09]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-08 02:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2300703005/#ps420001
(title: "for_landing!")

[commit-bot: I haz the power, 2016-09-08 02:55:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 04:41:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 04:41:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-09-08 06:36:49]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-08 06:37:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-08 07:53:07]

Description was changed from

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
==========

to

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).
==========

[pfeldman, 2016-09-08 07:53:17]

The CQ bit was unchecked by pfeldman@chromium.org

[pfeldman, 2016-09-08 07:53:26]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-08 07:53:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 07:59:42]

Description was changed from

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).
==========

to

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).
==========

[commit-bot: I haz the power, 2016-09-08 07:59:44]

Committed patchset #15 (id:420001)

[commit-bot: I haz the power, 2016-09-08 08:01:30]

Description was changed from

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).
==========

to

==========
DevTools: merge devtools_http_handler into content - it is used in all the
embedders anyways.

BUG=627517
TBR= changes to clients of the changed APIs.
NOTRY=true
(flaky try bot: https://codereview.chromium.org/2270333002).

Committed: https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451
Cr-Commit-Position: refs/heads/master@{#417223}
==========

[commit-bot: I haz the power, 2016-09-08 08:01:31]

Patchset 15 (id:??) landed as
https://crrev.com/1062876ae55867edab8ec43884e9b9e15d0fe451
Cr-Commit-Position: refs/heads/master@{#417223}