Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.cc

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for_landing! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_devtools_manager_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_devtools_manager_delegate.cc
diff --git a/headless/lib/browser/headless_devtools_manager_delegate.cc b/headless/lib/browser/headless_devtools_manager_delegate.cc
index ce89824097031edb287f2b3faaad3e99253bcf50..a53e8c773df368455afbcf1dbaf2e98d90f4015e 100644
--- a/headless/lib/browser/headless_devtools_manager_delegate.cc
+++ b/headless/lib/browser/headless_devtools_manager_delegate.cc
@@ -9,11 +9,14 @@
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/devtools_agent_host.h"
+#include "content/public/browser/devtools_frontend_host.h"
#include "content/public/browser/web_contents.h"
+#include "headless/grit/headless_lib_resources.h"
#include "headless/lib/browser/headless_browser_context_impl.h"
#include "headless/lib/browser/headless_browser_impl.h"
#include "headless/lib/browser/headless_web_contents_impl.h"
#include "headless/public/domains/browser.h"
+#include "ui/base/resource/resource_bundle.h"
namespace headless {
@@ -62,19 +65,14 @@ base::DictionaryValue* HeadlessDevToolsManagerDelegate::HandleCommand(
return result.release();
}
-std::string HeadlessDevToolsManagerDelegate::GetTargetType(
- content::RenderFrameHost* host) {
- return content::DevToolsAgentHost::kTypePage;
+std::string HeadlessDevToolsManagerDelegate::GetDiscoveryPageHTML() {
+ return ResourceBundle::GetSharedInstance().GetRawDataResource(
+ IDR_HEADLESS_LIB_DEVTOOLS_DISCOVERY_PAGE).as_string();
}
-std::string HeadlessDevToolsManagerDelegate::GetTargetTitle(
- content::RenderFrameHost* host) {
- return "";
-}
-
-scoped_refptr<content::DevToolsAgentHost>
-HeadlessDevToolsManagerDelegate::CreateNewTarget(const GURL& url) {
- return nullptr;
+std::string HeadlessDevToolsManagerDelegate::GetFrontendResource(
+ const std::string& path) {
+ return content::DevToolsFrontendHost::GetFrontendResource(path).as_string();
}
std::unique_ptr<base::Value> HeadlessDevToolsManagerDelegate::CreateTarget(
« no previous file with comments | « headless/lib/browser/headless_devtools_manager_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698