content/browser/devtools/forwarding_agent_host.cc - Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/forwarding_agent_host.cc

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)

Patch Set: for_landing! Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/forwarding_agent_host.cc

diff --git a/content/browser/devtools/forwarding_agent_host.cc b/content/browser/devtools/forwarding_agent_host.cc

index 599cf2ea038d6a67fb320898feda885e3f8c20f9..2166755d8c053fa469abf5663eb4d5c42b9dafd1 100644

--- a/content/browser/devtools/forwarding_agent_host.cc

+++ b/content/browser/devtools/forwarding_agent_host.cc

@@ -10,9 +10,10 @@

namespace content {

ForwardingAgentHost::ForwardingAgentHost(

- DevToolsExternalAgentProxyDelegate* delegate)

- : DevToolsAgentHostImpl(delegate->GetId()),

- delegate_(delegate) {

+ const std::string& id,

+ std::unique_ptr<DevToolsExternalAgentProxyDelegate> delegate)

+ : DevToolsAgentHostImpl(id),

+ delegate_(std::move(delegate)) {

}

ForwardingAgentHost::~ForwardingAgentHost() {