Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: content/public/browser/devtools_manager_delegate.h

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for_landing! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/devtools_manager_delegate.h
diff --git a/content/public/browser/devtools_manager_delegate.h b/content/public/browser/devtools_manager_delegate.h
index 67c00260569e91e64ec8c1a87b3f3c243fcda4fc..6ac50e3380c1ba548bd0883fe6036b90c7f0a888 100644
--- a/content/public/browser/devtools_manager_delegate.h
+++ b/content/public/browser/devtools_manager_delegate.h
@@ -7,6 +7,7 @@
#include <string>
#include "base/memory/ref_counted.h"
+#include "content/common/content_export.h"
#include "url/gurl.h"
namespace base {
@@ -19,29 +20,39 @@ class BrowserContext;
class DevToolsAgentHost;
class RenderFrameHost;
-class DevToolsManagerDelegate {
+class CONTENT_EXPORT DevToolsManagerDelegate {
public:
- virtual ~DevToolsManagerDelegate() {}
-
// Opens the inspector for |agent_host|.
- virtual void Inspect(DevToolsAgentHost* agent_host) = 0;
+ virtual void Inspect(DevToolsAgentHost* agent_host);
virtual void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,
- bool attached) = 0;
+ bool attached);
// Returns DevToolsAgentHost type to use for given |host| target.
- virtual std::string GetTargetType(RenderFrameHost* host) = 0;
+ virtual std::string GetTargetType(RenderFrameHost* host);
+
+ // Returns DevToolsAgentHost title to use for given |host| target.
+ virtual std::string GetTargetTitle(RenderFrameHost* host);
// Returns DevToolsAgentHost title to use for given |host| target.
- virtual std::string GetTargetTitle(RenderFrameHost* host) = 0;
+ virtual std::string GetTargetDescription(RenderFrameHost* host);
// Creates new inspectable target given the |url|.
- virtual scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url) = 0;
+ virtual scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url);
// Result ownership is passed to the caller.
virtual base::DictionaryValue* HandleCommand(
DevToolsAgentHost* agent_host,
- base::DictionaryValue* command) = 0;
+ base::DictionaryValue* command);
+
+ // Should return discovery page HTML that should list available tabs
+ // and provide attach links.
+ virtual std::string GetDiscoveryPageHTML();
+
+ // Returns frontend resource data by |path|.
+ virtual std::string GetFrontendResource(const std::string& path);
+
+ virtual ~DevToolsManagerDelegate();
};
} // namespace content
« no previous file with comments | « content/public/browser/devtools_external_agent_proxy_delegate.h ('k') | content/public/browser/devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698