Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: content/shell/browser/shell_devtools_manager_delegate.h

Issue 2300703005: DevTools: merge devtools_http_handler into content - it is used in all the embedders anyways. (Closed)
Patch Set: for_landing! Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/shell_devtools_manager_delegate.h
diff --git a/content/shell/browser/shell_devtools_manager_delegate.h b/content/shell/browser/shell_devtools_manager_delegate.h
index a4a9112981b707ea354bc5cf82f2928fc3878967..8e4ad5203227868d6a22c25ee122a5afd53811e0 100644
--- a/content/shell/browser/shell_devtools_manager_delegate.h
+++ b/content/shell/browser/shell_devtools_manager_delegate.h
@@ -7,21 +7,16 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "components/devtools_http_handler/devtools_http_handler_delegate.h"
#include "content/public/browser/devtools_manager_delegate.h"
-namespace devtools_http_handler {
-class DevToolsHttpHandler;
-}
-
namespace content {
class BrowserContext;
class ShellDevToolsManagerDelegate : public DevToolsManagerDelegate {
public:
- static devtools_http_handler::DevToolsHttpHandler* CreateHttpHandler(
- BrowserContext* browser_context);
+ static void StartHttpHandler(BrowserContext* browser_context);
+ static void StopHttpHandler();
explicit ShellDevToolsManagerDelegate(BrowserContext* browser_context);
~ShellDevToolsManagerDelegate() override;
@@ -30,11 +25,9 @@ class ShellDevToolsManagerDelegate : public DevToolsManagerDelegate {
void Inspect(DevToolsAgentHost* agent_host) override {}
void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,
bool attached) override {}
- base::DictionaryValue* HandleCommand(DevToolsAgentHost* agent_host,
- base::DictionaryValue* command) override;
- std::string GetTargetType(RenderFrameHost* host) override;
- std::string GetTargetTitle(RenderFrameHost* host) override;
scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url) override;
+ std::string GetDiscoveryPageHTML() override;
+ std::string GetFrontendResource(const std::string& path) override;
private:
BrowserContext* browser_context_;
« no previous file with comments | « content/shell/browser/shell_devtools_frontend.cc ('k') | content/shell/browser/shell_devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698