Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2299683002: Revert of Screenspace AA tessellated path rendering. (Closed)

Created:
4 years, 3 months ago by Stephen White
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Screenspace AA tessellated path rendering. (patchset #37 id:730001 of https://codereview.chromium.org/1152733009/ ) Reason for revert: Causing asserts in GLPrograms test on Mac. Original issue's description: > Screenspace AA tessellated GPU path rendering. > > This is an approach to antialiased concave path rendering > on the GPU without using MSAA. It uses GrTessellator to > extract boundary contours from the given path, then > inflates by half a pixel in screen space each direction, > then renders the result with zero alpha on the outer > contour and one alpha on in the inner contour. This > requires two passes through the tessellation code: one > to extract the boundaries, then one to tessellate the > result. > > This gives approximately a 3X improvement on the IE > chalkboard demo in non-MSAA mode, a 30-40% improvement > on MotionMark's "Fill Paths", and a ~3X improvement on > MotionMark's "canvas arcTo segments". > > It works best for large, simple paths, so there's currently > a limit of 10 verbs in the onCanDrawPath() check. This > dovetails nicely with the distance field path renderer's > support for small, detailed (and cached) paths. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1152733009 > > Committed: https://skia.googlesource.com/skia/+/9992bdef8ae97b3e5b109d278ccfab84c66bcbf0 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/682580fb204b72925a48d1d6fe8c9c30fa53bb67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -619 lines) Patch
M src/gpu/GrDefaultGeoProcFactory.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrPathRendererChain.cpp View 2 chunks +1 line, -1 line 0 comments Download
M src/gpu/GrTessellator.h View 3 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/GrTessellator.cpp View 35 chunks +100 lines, -448 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 12 chunks +68 lines, -157 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Stephen White
Created Revert of Screenspace AA tessellated path rendering.
4 years, 3 months ago (2016-08-31 16:31:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299683002/1
4 years, 3 months ago (2016-08-31 16:31:33 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 16:31:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/682580fb204b72925a48d1d6fe8c9c30fa53bb67

Powered by Google App Engine
This is Rietveld 408576698