Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2296513003: Delete AVDACopyingBackingStrategy and rename AVDADeferredRenderingBackingStrategy (Closed)

Created:
4 years, 3 months ago by watk
Modified:
4 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete AVDACopyingBackingStrategy and rename AVDADeferredRenderingBackingStrategy AVDACopyingBackingStrategy is unused so it's now deleted. Since we only have a single strategy left, it's renamed to AVDAPictureBufferManager, since its role is mostly to associate PictureBuffers with MediaCodec buffers. BUG=637463 Committed: https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659 Cr-Commit-Position: refs/heads/master@{#415803}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undelete & fix unittest #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -1124 lines) Patch
M media/gpu/BUILD.gn View 1 1 chunk +2 lines, -5 lines 0 comments Download
D media/gpu/android_copying_backing_strategy.h View 1 chunk +0 lines, -71 lines 0 comments Download
D media/gpu/android_copying_backing_strategy.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D media/gpu/android_deferred_rendering_backing_strategy.h View 1 chunk +0 lines, -107 lines 0 comments Download
D media/gpu/android_deferred_rendering_backing_strategy.cc View 1 chunk +0 lines, -314 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.h View 9 chunks +11 lines, -108 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 25 chunks +54 lines, -214 lines 3 comments Download
M media/gpu/android_video_decode_accelerator_unittest.cc View 1 2 chunks +31 lines, -25 lines 0 comments Download
A media/gpu/avda_picture_buffer_manager.h View 1 1 chunk +121 lines, -0 lines 0 comments Download
A + media/gpu/avda_picture_buffer_manager.cc View 1 12 chunks +149 lines, -54 lines 0 comments Download
D media/gpu/avda_return_on_failure.h View 1 chunk +0 lines, -34 lines 0 comments Download
M media/gpu/avda_state_provider.h View 2 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
watk
4 years, 3 months ago (2016-08-30 01:00:33 UTC) #3
liberato (no reviews please)
lgtm % all the android bots failed :) nice. -fl https://codereview.chromium.org/2296513003/diff/1/media/gpu/avda_picture_buffer_manager.cc File media/gpu/avda_picture_buffer_manager.cc (left): https://codereview.chromium.org/2296513003/diff/1/media/gpu/avda_picture_buffer_manager.cc#oldcode68 ...
4 years, 3 months ago (2016-08-30 14:45:58 UTC) #7
watk
Fixed the unittest so that it would have caught the bug you noticed :) I ...
4 years, 3 months ago (2016-08-31 20:35:35 UTC) #11
watk
BTW, PTAL for changes to avda_unittest
4 years, 3 months ago (2016-08-31 21:22:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2296513003/40001
4 years, 3 months ago (2016-08-31 23:24:00 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 3 months ago (2016-08-31 23:29:01 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4b2ccc21abd7383301000507b1cdbf7696deb659 Cr-Commit-Position: refs/heads/master@{#415803}
4 years, 3 months ago (2016-08-31 23:32:20 UTC) #20
Pawel Osciak
https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video_decode_accelerator.cc File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video_decode_accelerator.cc#newcode496 media/gpu/android_video_decode_accelerator.cc:496: auto gles_decoder = get_gles2_decoder_cb_.Run(); I think gles_decoder is not ...
4 years, 3 months ago (2016-09-01 01:04:29 UTC) #22
watk
https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video_decode_accelerator.cc File media/gpu/android_video_decode_accelerator.cc (right): https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video_decode_accelerator.cc#newcode496 media/gpu/android_video_decode_accelerator.cc:496: auto gles_decoder = get_gles2_decoder_cb_.Run(); On 2016/09/01 01:04:29, Pawel Osciak ...
4 years, 3 months ago (2016-09-01 17:03:33 UTC) #23
Pawel Osciak
4 years, 3 months ago (2016-09-02 06:03:03 UTC) #24
Message was sent while issue was closed.
https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video...
File media/gpu/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/2296513003/diff/40001/media/gpu/android_video...
media/gpu/android_video_decode_accelerator.cc:496: auto gles_decoder =
get_gles2_decoder_cb_.Run();
On 2016/09/01 17:03:33, watk wrote:
> On 2016/09/01 01:04:29, Pawel Osciak wrote:
> > I think gles_decoder is not needed anymore? Could it be removed please? I
> think
> > we should also be able to remove it from GpuVideoDecodeAcceleratorFactory as
> > well then...?
> 
> I would love to, but we still use it. We pass it to AVDAPictureBufferManager
> which mainly uses it for interacting with the TextureManager. The way we
attach
> MediaCodec buffers to PictureBuffers without copying means we have to be able
to
> attach GLImages through the TextureManager. 

I see, thanks!

Powered by Google App Engine
This is Rietveld 408576698