Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 229393002: Fixes to Android.mk generation for arm64. (Closed)

Created:
6 years, 8 months ago by scroggo
Modified:
6 years, 8 months ago
Reviewers:
hal.canary, djsollen
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fixes to Android.mk generation for arm64. Remove warning about no optimizations for arm64 and rebaseline the associated test. Exclude _opts_none.cpps when building arm64, to avoid double definitions. BUG=skia:1975 Committed: http://code.google.com/p/skia/source/detail?r=14104

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M gyp/opts.gyp View 1 chunk +1 line, -1 line 2 comments Download
M platform_tools/android/gyp_gen/makefile_writer.py View 1 chunk +0 lines, -5 lines 0 comments Download
M platform_tools/android/tests/expectations/Android.mk View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
https://codereview.chromium.org/229393002/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.chromium.org/229393002/diff/1/gyp/opts.gyp#newcode106 gyp/opts.gyp:106: or (skia_os == "android" and skia_arch_type not in ["x86", ...
6 years, 8 months ago (2014-04-08 22:05:32 UTC) #1
djsollen
lgtm https://codereview.chromium.org/229393002/diff/1/gyp/opts.gyp File gyp/opts.gyp (right): https://codereview.chromium.org/229393002/diff/1/gyp/opts.gyp#newcode106 gyp/opts.gyp:106: or (skia_os == "android" and skia_arch_type not in ...
6 years, 8 months ago (2014-04-09 13:18:36 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 8 months ago (2014-04-09 13:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/229393002/1
6 years, 8 months ago (2014-04-09 13:19:10 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 13:34:29 UTC) #5
Message was sent while issue was closed.
Change committed as 14104

Powered by Google App Engine
This is Rietveld 408576698