platform_tools/android/gyp_gen/makefile_writer.py - Issue 229393002: Fixes to Android.mk generation for arm64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 229393002: Fixes to Android.mk generation for arm64. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp_gen/makefile_writer.py

diff --git a/platform_tools/android/gyp_gen/makefile_writer.py b/platform_tools/android/gyp_gen/makefile_writer.py

index f4cdbef44dd352ef7fce07d7bcf202046961db0a..1b977ca1e65efd323d36a57a91156d010e28d5a1 100644

--- a/platform_tools/android/gyp_gen/makefile_writer.py

+++ b/platform_tools/android/gyp_gen/makefile_writer.py

@@ -195,11 +195,6 @@ def write_android_mk(target_dir, common, deviations_from_common):

f.write('\tLOCAL_CFLAGS += -DNO_FALLBACK_FONT\n')

f.write('endif\n\n')

- f.write('ifeq ($(TARGET_ARCH),arm64)\n')

- f.write(' $(warning TODOArm64: Unlike arm32, arm64 has no inline'

- ' assembly for performance critical code.)\n')

- f.write('endif\n\n')

write_local_vars(f, common, False, None)

for data in deviations_from_common: