Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 229393002: Fixes to Android.mk generation for arm64. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright 2014 Google Inc. 3 # Copyright 2014 Google Inc.
4 # 4 #
5 # Use of this source code is governed by a BSD-style license that can be 5 # Use of this source code is governed by a BSD-style license that can be
6 # found in the LICENSE file. 6 # found in the LICENSE file.
7 7
8 """ 8 """
9 Functions for creating an Android.mk from already created dictionaries. 9 Functions for creating an Android.mk from already created dictionaries.
10 """ 10 """
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
188 f.write('\tLOCAL_CFLAGS += -DANDROID_LARGE_MEMORY_DEVICE\n') 188 f.write('\tLOCAL_CFLAGS += -DANDROID_LARGE_MEMORY_DEVICE\n')
189 f.write('endif\n\n') 189 f.write('endif\n\n')
190 190
191 f.write('# used for testing\n') 191 f.write('# used for testing\n')
192 f.write('#LOCAL_CFLAGS += -g -O0\n\n') 192 f.write('#LOCAL_CFLAGS += -g -O0\n\n')
193 193
194 f.write('ifeq ($(NO_FALLBACK_FONT),true)\n') 194 f.write('ifeq ($(NO_FALLBACK_FONT),true)\n')
195 f.write('\tLOCAL_CFLAGS += -DNO_FALLBACK_FONT\n') 195 f.write('\tLOCAL_CFLAGS += -DNO_FALLBACK_FONT\n')
196 f.write('endif\n\n') 196 f.write('endif\n\n')
197 197
198 f.write('ifeq ($(TARGET_ARCH),arm64)\n')
199 f.write(' $(warning TODOArm64: Unlike arm32, arm64 has no inline'
200 ' assembly for performance critical code.)\n')
201 f.write('endif\n\n')
202
203 write_local_vars(f, common, False, None) 198 write_local_vars(f, common, False, None)
204 199
205 for data in deviations_from_common: 200 for data in deviations_from_common:
206 if data.condition: 201 if data.condition:
207 f.write('ifeq ($(%s), true)\n' % data.condition) 202 f.write('ifeq ($(%s), true)\n' % data.condition)
208 write_local_vars(f, data.vars_dict, True, data.name) 203 write_local_vars(f, data.vars_dict, True, data.name)
209 if data.condition: 204 if data.condition:
210 f.write('endif\n\n') 205 f.write('endif\n\n')
211 206
212 f.write('include external/stlport/libstlport.mk\n') 207 f.write('include external/stlport/libstlport.mk\n')
213 f.write('LOCAL_MODULE:= libskia\n') 208 f.write('LOCAL_MODULE:= libskia\n')
214 f.write('include $(BUILD_SHARED_LIBRARY)\n') 209 f.write('include $(BUILD_SHARED_LIBRARY)\n')
215 f.write(SKIA_TOOLS) 210 f.write(SKIA_TOOLS)
216 211
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698