Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: gyp/opts.gyp

Issue 229393002: Fixes to Android.mk generation for arm64. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/makefile_writer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/opts.gyp
diff --git a/gyp/opts.gyp b/gyp/opts.gyp
index 783ea4eb7afd8cc98c2f97c70c173c6b4f5aed6b..745259f75099ee2d28ed3ceb81cbd1ed05bc79e6 100644
--- a/gyp/opts.gyp
+++ b/gyp/opts.gyp
@@ -103,7 +103,7 @@
}],
[ '(skia_arch_type == "mips") or (skia_arch_type == "arm" and arm_version < 7) \
or (skia_os == "ios") \
- or (skia_os == "android" and skia_arch_type not in ["x86", "arm", "mips"])', {
+ or (skia_os == "android" and skia_arch_type not in ["x86", "arm", "mips", "arm64"])', {
scroggo 2014/04/08 22:05:37 I'm surprised this didn't cause problems on the bo
djsollen 2014/04/09 13:18:36 The bot is building with linux as the skia_os not
'sources': [
'../src/opts/SkBitmapProcState_opts_none.cpp',
'../src/opts/SkBlitMask_opts_none.cpp',
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/makefile_writer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698