Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: gyp/opts.gyp

Issue 229393002: Fixes to Android.mk generation for arm64. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/makefile_writer.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Gyp file for opts projects 1 # Gyp file for opts projects
2 { 2 {
3 'targets': [ 3 'targets': [
4 # Due to an unfortunate intersection of lameness between gcc and gyp, 4 # Due to an unfortunate intersection of lameness between gcc and gyp,
5 # we have to build the *_SSE2.cpp files in a separate target. The 5 # we have to build the *_SSE2.cpp files in a separate target. The
6 # gcc lameness is that, in order to compile SSE2 intrinsics code, it 6 # gcc lameness is that, in order to compile SSE2 intrinsics code, it
7 # must be passed the -msse2 flag. However, with this flag, it may 7 # must be passed the -msse2 flag. However, with this flag, it may
8 # emit SSE2 instructions even for scalar code, such as the CPUID 8 # emit SSE2 instructions even for scalar code, such as the CPUID
9 # test used to test for the presence of SSE2. So that, and all other 9 # test used to test for the presence of SSE2. So that, and all other
10 # code must be compiled *without* -msse2. The gyp lameness is that it 10 # code must be compiled *without* -msse2. The gyp lameness is that it
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 # these fail to compile under xcode for ios 96 # these fail to compile under xcode for ios
97 '../src/opts/memset.arm.S', 97 '../src/opts/memset.arm.S',
98 '../src/opts/SkBitmapProcState_opts_arm.cpp', 98 '../src/opts/SkBitmapProcState_opts_arm.cpp',
99 '../src/opts/SkBlitRow_opts_arm.cpp', 99 '../src/opts/SkBlitRow_opts_arm.cpp',
100 ], 100 ],
101 }], 101 }],
102 ], 102 ],
103 }], 103 }],
104 [ '(skia_arch_type == "mips") or (skia_arch_type == "arm" and arm_versio n < 7) \ 104 [ '(skia_arch_type == "mips") or (skia_arch_type == "arm" and arm_versio n < 7) \
105 or (skia_os == "ios") \ 105 or (skia_os == "ios") \
106 or (skia_os == "android" and skia_arch_type not in ["x86", "arm", "m ips"])', { 106 or (skia_os == "android" and skia_arch_type not in ["x86", "arm", "m ips", "arm64"])', {
scroggo 2014/04/08 22:05:37 I'm surprised this didn't cause problems on the bo
djsollen 2014/04/09 13:18:36 The bot is building with linux as the skia_os not
107 'sources': [ 107 'sources': [
108 '../src/opts/SkBitmapProcState_opts_none.cpp', 108 '../src/opts/SkBitmapProcState_opts_none.cpp',
109 '../src/opts/SkBlitMask_opts_none.cpp', 109 '../src/opts/SkBlitMask_opts_none.cpp',
110 '../src/opts/SkBlitRow_opts_none.cpp', 110 '../src/opts/SkBlitRow_opts_none.cpp',
111 '../src/opts/SkBlurImage_opts_none.cpp', 111 '../src/opts/SkBlurImage_opts_none.cpp',
112 '../src/opts/SkMorphology_opts_none.cpp', 112 '../src/opts/SkMorphology_opts_none.cpp',
113 '../src/opts/SkUtils_opts_none.cpp', 113 '../src/opts/SkUtils_opts_none.cpp',
114 '../src/opts/SkXfermode_opts_none.cpp', 114 '../src/opts/SkXfermode_opts_none.cpp',
115 ], 115 ],
116 }], 116 }],
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 '../src/opts/SkBitmapProcState_matrix_neon.h', 215 '../src/opts/SkBitmapProcState_matrix_neon.h',
216 '../src/opts/SkBlitMask_opts_arm_neon.cpp', 216 '../src/opts/SkBlitMask_opts_arm_neon.cpp',
217 '../src/opts/SkBlitRow_opts_arm_neon.cpp', 217 '../src/opts/SkBlitRow_opts_arm_neon.cpp',
218 '../src/opts/SkBlurImage_opts_neon.cpp', 218 '../src/opts/SkBlurImage_opts_neon.cpp',
219 '../src/opts/SkMorphology_opts_neon.cpp', 219 '../src/opts/SkMorphology_opts_neon.cpp',
220 '../src/opts/SkXfermode_opts_arm_neon.cpp', 220 '../src/opts/SkXfermode_opts_arm_neon.cpp',
221 ], 221 ],
222 }, 222 },
223 ], 223 ],
224 } 224 }
OLDNEW
« no previous file with comments | « no previous file | platform_tools/android/gyp_gen/makefile_writer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698