Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2292173002: Roll clang 278861:280106. (Closed)

Created:
4 years, 3 months ago by Nico
Modified:
4 years, 3 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, Reid Kleckner, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 278861:280106. * win: Members of base classes now should show up in debugger. * win: Debugger shouldn't show funny highlights anymore due to debug info no longer including column information. (we still force this on if sanitizers are used, mostly for clusterfuzz. maybe we want to make this toggleable independent of sanitizers at some point) * win: -Wextern-initializer no longer warns on midl-generated code * win: clang-cl now accepts /source-encoding:utf-8 and friends (utf-8 was the source enconding in clang-cl before already, but now we don't warn on an explicit flag requesting this) * all platforms: Three plugin checks are now on-by-default, remove flags for these (see https://codereview.chromium.org/2267713003 https://codereview.chromium.org/2268203002 https://codereview.chromium.org/2265093002 ) * win: clang-cl's /Brepro now does what it's supposed to do * win: clang-cl now emits absolute paths in diagnostics, by popular request. Ran `tools/clang/scripts/upload_revision.py 280106`. BUG=640254, 637456, 636109, 636091, 636099 Committed: https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23 Cr-Commit-Position: refs/heads/master@{#415563}

Patch Set 1 #

Patch Set 2 : columns #

Patch Set 3 : flag tweaks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M build/config/clang/BUILD.gn View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +1 line, -2 lines 1 comment Download
M build/config/sanitizers/BUILD.gn View 1 2 1 chunk +8 lines, -1 line 0 comments Download
M build/config/win/BUILD.gn View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (14 generated)
hans
lgtm if the bots like it https://codereview.chromium.org/2292173002/diff/30001/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (left): https://codereview.chromium.org/2292173002/diff/30001/build/config/compiler/BUILD.gn#oldcode375 build/config/compiler/BUILD.gn:375: # TODO(hans) Remove ...
4 years, 3 months ago (2016-08-30 20:58:22 UTC) #12
Nico
Bots look pretty happy now, cq'ing…
4 years, 3 months ago (2016-08-31 01:58:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292173002/30001
4 years, 3 months ago (2016-08-31 01:58:48 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 3 months ago (2016-08-31 05:16:31 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/a033f395bf2547cf4764f77cc9c86d08f3e22c23 Cr-Commit-Position: refs/heads/master@{#415563}
4 years, 3 months ago (2016-08-31 05:18:50 UTC) #19
scottmg
4 years, 3 months ago (2016-08-31 05:31:16 UTC) #20
Message was sent while issue was closed.
\o/ exciting! I will try switching again. :)

Powered by Google App Engine
This is Rietveld 408576698