Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: build/config/win/BUILD.gn

Issue 2292173002: Roll clang 278861:280106. (Closed)
Patch Set: flag tweaks Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/win/BUILD.gn
diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn
index c778bf2ab4f9df95145610eaa9fdaf1c5b7bb4b6..a65997bf44c0f0bae8c794aee8bba499f30db3da 100644
--- a/build/config/win/BUILD.gn
+++ b/build/config/win/BUILD.gn
@@ -402,13 +402,7 @@ config("target_winrt") {
# Config used by the MIDL template to disable warnings.
config("midl_warnings") {
if (is_clang) {
- cflags = [
- # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
- "-Wno-extra-tokens",
-
- # TODO(thakis): Remove this once clang is rolled past r279116,
- # https://crbug.com/637456
- "-Wno-extern-initializer",
- ]
+ # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
+ cflags = [ "-Wno-extra-tokens" ]
}
}

Powered by Google App Engine
This is Rietveld 408576698