clang plugin: Remove check-templates toggle.

clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916
R=dcheng@chromium.org

Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Commit-Position: refs/heads/master@{#413546}
Committed: https://chromium.googlesource.com/chromium/src/+/1708d758f7cb9bc9543e0ee634bae4c5a52d3bc8

[Nico, 2016-08-22 20:55:17]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-08-22 20:55:30]

thakis@chromium.org changed reviewers:
+ dcheng@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:56:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-08-22 20:56:29]

lgtm

[Nico, 2016-08-22 20:57:42]

The CQ bit was unchecked by thakis@chromium.org

[Nico, 2016-08-22 20:57:47]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-08-22 20:58:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:53:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-22 21:57:23]

Description was changed from

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916
==========

to

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916

Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Commit-Position: refs/heads/master@{#413546}
==========

[commit-bot: I haz the power, 2016-08-22 21:57:24]

Patchset 1 (id:??) landed as
https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Commit-Position: refs/heads/master@{#413546}

[hans, 2016-08-24 23:33:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2278603004/ by hans@chromium.org.

The reason for reverting is: This broke the weak_ptr_factory.cpp test:
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...

I think this check effectively always disabled the check-templates flag instead
of always enabling it.

And it sucks that we didn't notice for two days :-(.

[hans, 2016-08-24 23:33:19]

hans@chromium.org changed reviewers:
+ hans@chromium.org

[hans, 2016-08-24 23:33:19]

https://codereview.chromium.org/2267713003/diff/1/tools/clang/plugins/FindBad...
File tools/clang/plugins/FindBadConstructsConsumer.cpp (left):

https://codereview.chromium.org/2267713003/diff/1/tools/clang/plugins/FindBad...
tools/clang/plugins/FindBadConstructsConsumer.cpp:224: if
(!options_.check_templates && IsPodOrTemplateType(*record))
Wait, if options_.check_templates is always true, doesn't that mean we should
never return here, i.e. the whole if-statement (and comment above) should be
killed?

[Nico, 2016-08-25 01:17:08]

On 2016/08/24 23:33:09, hans wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2278603004/ by mailto:hans@chromium.org.
> 
> The reason for reverting is: This broke the weak_ptr_factory.cpp test:
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...
> 
> I think this check effectively always disabled the check-templates flag
instead
> of always enabling it.
> 
> And it sucks that we didn't notice for two days :-(.

Bleh, sorry for not checking the tot bots. (who's sheriff this week?)

[dcheng, 2016-08-25 01:20:30]

On 2016/08/25 01:17:08, Nico wrote:
> On 2016/08/24 23:33:09, hans wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2278603004/ by mailto:hans@chromium.org.
> > 
> > The reason for reverting is: This broke the weak_ptr_factory.cpp test:
> >
>
https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/...
> > 
> > I think this check effectively always disabled the check-templates flag
> instead
> > of always enabling it.
> > 
> > And it sucks that we didn't notice for two days :-(.
> 
> Bleh, sorry for not checking the tot bots. (who's sheriff this week?)

Sorry for missing this in review =(

[Nico, 2016-08-25 14:13:15]

Trying again in patch set 2.

[commit-bot: I haz the power, 2016-08-25 14:19:44]

Description was changed from

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916

Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Commit-Position: refs/heads/master@{#413546}
==========

to

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916
R=dcheng@chromium.org

Committed: https://crrev.com/1708d758f7cb9bc9543e0ee634bae4c5a52d3bc8
Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Original-Commit-Position: refs/heads/master@{#413546}
Cr-Commit-Position: refs/heads/master@{#414430}
==========

[commit-bot: I haz the power, 2016-08-25 14:19:45]

Patchset 2 (id:??) landed as
https://crrev.com/1708d758f7cb9bc9543e0ee634bae4c5a52d3bc8
Cr-Commit-Position: refs/heads/master@{#414430}

[Nico, 2016-08-25 14:20:50]

Description was changed from

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916
R=dcheng@chromium.org

Committed: https://crrev.com/1708d758f7cb9bc9543e0ee634bae4c5a52d3bc8
Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Original-Commit-Position: refs/heads/master@{#413546}
Cr-Commit-Position: refs/heads/master@{#414430}
==========

to

==========
clang plugin: Remove check-templates toggle.

It's been on by default for a long time.

BUG=441916
R=dcheng@chromium.org

Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
Cr-Commit-Position: refs/heads/master@{#413546}
Committed:
https://chromium.googlesource.com/chromium/src/+/1708d758f7cb9bc9543e0ee634ba...
==========

[Nico, 2016-08-25 14:20:52]

Committed patchset #2 (id:20001) manually as
1708d758f7cb9bc9543e0ee634bae4c5a52d3bc8 (presubmit successful).