Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2265093002: clang plugin: Remove follow-macro-expansion toggle (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang plugin: Remove follow-macro-expansion toggle It has been enabled by default since https://codereview.chromium.org/1529323002/ BUG=156590 Committed: https://crrev.com/3fc38173211d77587e9656123325dc3387728de6 Cr-Commit-Position: refs/heads/master@{#413461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M tools/clang/plugins/ChromeClassTester.cpp View 1 chunk +11 lines, -21 lines 0 comments Download
M tools/clang/plugins/FindBadConstructsAction.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tools/clang/plugins/Options.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Nico
4 years, 4 months ago (2016-08-22 14:17:26 UTC) #3
Jeffrey Yasskin
LGTM. Sorry for not following through with this.
4 years, 4 months ago (2016-08-22 17:14:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2265093002/1
4 years, 4 months ago (2016-08-22 17:16:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 17:21:45 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:23:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3fc38173211d77587e9656123325dc3387728de6
Cr-Commit-Position: refs/heads/master@{#413461}

Powered by Google App Engine
This is Rietveld 408576698