Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2292173002: Roll clang 278861:280106. (Closed)
Patch Set: flag tweaks Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index 4b96dd446c1f3d3431ab2bc5485dfcb1e89aca05..73bafa9891c858cab0a14a595a32cf9ebf99784a 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -231,7 +231,14 @@ config("common_sanitizer_flags") {
# or variable info, so we can leave that out to speed up the build.
if (using_sanitizer) {
assert(is_clang, "sanitizers only supported with clang")
- cflags += [ "-gline-tables-only" ]
+ cflags += [
+ "-gline-tables-only",
+
+ # Column info in debug data confuses Visual Studio's debugger, so don't
+ # use this by default. However, clusterfuzz needs it for good attribution
+ # of reports to CLs, so turn it on there.
+ "-gcolumn-info",
+ ]
}
# Common options for AddressSanitizer, LeakSanitizer, ThreadSanitizer,

Powered by Google App Engine
This is Rietveld 408576698