Rename ash desktop_background to wallpaper.

Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org

Committed: https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b
Cr-Commit-Position: refs/heads/master@{#415335}

[msw, 2016-08-30 00:23:58]

Description was changed from

==========
Rename ash desktop_background to wallpaper.

BUG=629605
==========

to

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
==========

[msw, 2016-08-30 00:23:58]

msw@chromium.org changed reviewers:
+ jamescook@chromium.org

[msw, 2016-08-30 00:24:08]

Patchset #2 (id:20001) has been deleted

[msw, 2016-08-30 00:24:30]

Hey James, please take a look; thanks!

[msw, 2016-08-30 00:51:21]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 02:11:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:42:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:42:38]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-08-30 05:18:20]

LGTM with nits. I'm surprised by how much wallpaper code we have. Wow.

https://codereview.chromium.org/2290473004/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller_delegate_aura.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_controller_delegate_aura.cc:367: case
DEBUG_TOGGLE_WALLPAPER_MODE:
nit: alphabetize, here and below

https://codereview.chromium.org/2290473004/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_table.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_table.h:61: DEBUG_TOGGLE_WALLPAPER_MODE,
nit: alphabetize

https://codereview.chromium.org/2290473004/diff/40001/ash/common/root_window_...
File ash/common/root_window_controller_common.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/common/root_window_...
ash/common/root_window_controller_common.cc:45:
kShellWindowId_WallpaperContainer, "WallpaperContainer", root_);
Nice that you renamed the container too.

https://codereview.chromium.org/2290473004/diff/40001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_delegate_mus.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_delegate_mus.cc:23: case
DEBUG_TOGGLE_WALLPAPER_MODE:
nit: alphabetize

https://codereview.chromium.org/2290473004/diff/40001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/shell.h#newcode277
ash/shell.h:277: WallpaperController* wallpaper_controller() {
optional: It's a bummer that Shell::wallpaper_controller() returns a
WallpaperController, but RootWindowController::wallpaper_controller() returns a
WallpaperWidgetController. Do you think it's worth having the latter be called
wallpaper_widget_controller()? Or is that too much code churn?

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
File ash/wallpaper/wallpaper_controller.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_controller.cc:224: // can temporarily be two wallpaper
wallpaper widgets. We must reparent both
nit: wallpaper wallpaper -> wallpaper

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_controller.cc:237: }
Aside: I once spent ~2 weeks tracking down a bug to this function. It only
reproduced on one particular Chromebook that had a spinning disk instead of
flash. There was exactly 1 Googler who could reliably repro it, but only in the
field, and not if I added logging.

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
File ash/wallpaper/wallpaper_widget_controller.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_widget_controller.h:29: // Create
nit: remove this

https://codereview.chromium.org/2290473004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/login_display_host_impl.cc:847: // For new
user, move wallpaper to locker container so that windows
nit: locker -> lock or locked

[msw, 2016-08-30 16:07:29]

Description was changed from

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
==========

to

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org
==========

[msw, 2016-08-30 16:07:29]

msw@chromium.org changed reviewers:
+ jochen@chromium.org, sky@chromium.org, tsepez@chromium.org

[msw, 2016-08-30 16:08:00]

Comments addressed; TBR'ing [deps] owners for simple renaming.

https://codereview.chromium.org/2290473004/diff/40001/ash/accelerators/accele...
File ash/accelerators/accelerator_controller_delegate_aura.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/accelerators/accele...
ash/accelerators/accelerator_controller_delegate_aura.cc:367: case
DEBUG_TOGGLE_WALLPAPER_MODE:
On 2016/08/30 05:18:19, James Cook wrote:
> nit: alphabetize, here and below

Done.

https://codereview.chromium.org/2290473004/diff/40001/ash/common/accelerators...
File ash/common/accelerators/accelerator_table.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/common/accelerators...
ash/common/accelerators/accelerator_table.h:61: DEBUG_TOGGLE_WALLPAPER_MODE,
On 2016/08/30 05:18:19, James Cook wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/2290473004/diff/40001/ash/common/root_window_...
File ash/common/root_window_controller_common.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/common/root_window_...
ash/common/root_window_controller_common.cc:45:
kShellWindowId_WallpaperContainer, "WallpaperContainer", root_);
On 2016/08/30 05:18:19, James Cook wrote:
> Nice that you renamed the container too.

Acknowledged.

https://codereview.chromium.org/2290473004/diff/40001/ash/mus/accelerators/ac...
File ash/mus/accelerators/accelerator_controller_delegate_mus.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/mus/accelerators/ac...
ash/mus/accelerators/accelerator_controller_delegate_mus.cc:23: case
DEBUG_TOGGLE_WALLPAPER_MODE:
On 2016/08/30 05:18:19, James Cook wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/2290473004/diff/40001/ash/shell.h
File ash/shell.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/shell.h#newcode277
ash/shell.h:277: WallpaperController* wallpaper_controller() {
On 2016/08/30 05:18:19, James Cook wrote:
> optional: It's a bummer that Shell::wallpaper_controller() returns a
> WallpaperController, but RootWindowController::wallpaper_controller() returns
a
> WallpaperWidgetController. Do you think it's worth having the latter be called
> wallpaper_widget_controller()? Or is that too much code churn?

Fixed the RootWindowController accessors (and renamed
AnimationWallpaperWidgetController)

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
File ash/wallpaper/wallpaper_controller.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_controller.cc:224: // can temporarily be two wallpaper
wallpaper widgets. We must reparent both
On 2016/08/30 05:18:19, James Cook wrote:
> nit: wallpaper wallpaper -> wallpaper

Done.

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_controller.cc:237: }
On 2016/08/30 05:18:19, James Cook wrote:
> Aside: I once spent ~2 weeks tracking down a bug to this function. It only
> reproduced on one particular Chromebook that had a spinning disk instead of
> flash. There was exactly 1 Googler who could reliably repro it, but only in
the
> field, and not if I added logging.

Yikes!

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
File ash/wallpaper/wallpaper_widget_controller.h (right):

https://codereview.chromium.org/2290473004/diff/40001/ash/wallpaper/wallpaper...
ash/wallpaper/wallpaper_widget_controller.h:29: // Create
On 2016/08/30 05:18:20, James Cook wrote:
> nit: remove this

Done.

https://codereview.chromium.org/2290473004/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/login_display_host_impl.cc (right):

https://codereview.chromium.org/2290473004/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/login_display_host_impl.cc:847: // For new
user, move wallpaper to locker container so that windows
On 2016/08/30 05:18:20, James Cook wrote:
> nit: locker -> lock or locked

Done.

[msw, 2016-08-30 16:08:08]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-30 16:08:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2290473004/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-30 16:08:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-30 17:06:59]

RS LGTM on mojom

[commit-bot: I haz the power, 2016-08-30 17:22:59]

Description was changed from

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org
==========

to

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 17:23:00]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-08-30 17:24:28]

Description was changed from

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org
==========

to

==========
Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG=629605
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org

Committed: https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b
Cr-Commit-Position: refs/heads/master@{#415335}
==========

[commit-bot: I haz the power, 2016-08-30 17:24:29]

Patchset 3 (id:??) landed as
https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b
Cr-Commit-Position: refs/heads/master@{#415335}