Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: ash/common/root_window_controller_common.cc

Issue 2290473004: Rename ash desktop_background to wallpaper. (Closed)
Patch Set: Address comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/accelerators/accelerator_table.cc ('k') | ash/common/shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/root_window_controller_common.cc
diff --git a/ash/common/root_window_controller_common.cc b/ash/common/root_window_controller_common.cc
index cfaa065a3597d5047882ab4c879895e4dbbffaf7..0a8008fd1742895f90e7521879ef2ec240ba80c5 100644
--- a/ash/common/root_window_controller_common.cc
+++ b/ash/common/root_window_controller_common.cc
@@ -37,15 +37,13 @@ void RootWindowControllerCommon::CreateContainers() {
// on those containers. These are direct children of the root window; all of
// the other containers are their children.
- // The desktop background container is not part of the lock animation, so it
- // is not included in those animate groups.
- // When screen is locked desktop background is moved to lock screen background
- // container (moved back on unlock). We want to make sure that there's an
- // opaque layer occluding the non-lock-screen layers.
- WmWindow* desktop_background_container =
- CreateContainer(kShellWindowId_DesktopBackgroundContainer,
- "DesktopBackgroundContainer", root_);
- desktop_background_container->SetChildWindowVisibilityChangesAnimated();
+ // The wallpaper container is not part of the lock animation, so it is not
+ // included in those animate groups. When the screen is locked, the wallpaper
+ // is moved to the lock screen wallpaper container (and moved back on unlock).
+ // Ensure that there's an opaque layer occluding the non-lock-screen layers.
+ WmWindow* wallpaper_container = CreateContainer(
+ kShellWindowId_WallpaperContainer, "WallpaperContainer", root_);
+ wallpaper_container->SetChildWindowVisibilityChangesAnimated();
WmWindow* non_lock_screen_containers =
CreateContainer(kShellWindowId_NonLockScreenContainersContainer,
@@ -54,10 +52,10 @@ void RootWindowControllerCommon::CreateContainers() {
// texture may become visible when the screen is scaled. crbug.com/368591.
non_lock_screen_containers->SetMasksToBounds(true);
- WmWindow* lock_background_containers =
- CreateContainer(kShellWindowId_LockScreenBackgroundContainer,
- "LockScreenBackgroundContainer", root_);
- lock_background_containers->SetChildWindowVisibilityChangesAnimated();
+ WmWindow* lock_wallpaper_containers =
+ CreateContainer(kShellWindowId_LockScreenWallpaperContainer,
+ "LockScreenWallpaperContainer", root_);
+ lock_wallpaper_containers->SetChildWindowVisibilityChangesAnimated();
WmWindow* lock_screen_containers =
CreateContainer(kShellWindowId_LockScreenContainersContainer,
« no previous file with comments | « ash/common/accelerators/accelerator_table.cc ('k') | ash/common/shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698