Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

CPDFSDK_Annot::GetType should be renamed to GetAnnotSubtype as it returns
annotation subtype. Also, CPDFSDK_Annot::GetSubType is only used to check if
the annotation is signature widget. Thus, change the method to
IsSignatureWidget.  Lastly, rename CPDF_Annot::GetSubType to
CPDF_Annot::GetSubtype to match with spec.

Committed: https://pdfium.googlesource.com/pdfium/+/9ed91376d562f3c6e7ca0a99035a74502f648776

[jaepark, 2016-08-26 20:59:53]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 20:59:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:11:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:11:40]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-26 21:12:34]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[Lei Zhang, 2016-08-26 21:16:14]

https://codereview.chromium.org/2287703002/diff/1/fpdfsdk/cba_annotiterator.cpp
File fpdfsdk/cba_annotiterator.cpp (right):

https://codereview.chromium.org/2287703002/diff/1/fpdfsdk/cba_annotiterator.c...
fpdfsdk/cba_annotiterator.cpp:129: pAnnot->GetSubType() == m_sSubType)
There's some SubType vs Subtype inconsistencies.

[jaepark, 2016-08-26 21:44:14]

Description was changed from

==========
Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

CPDFSDK_Annot::GetType should be renamed to GetAnnotSubtype as it
returns annotation subtype. Also, rename CPDF_Annot::GetSubType to
CPDF_Annot::GetSubtype to match with spec.
==========

to

==========
Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

CPDFSDK_Annot::GetType should be renamed to GetAnnotSubtype as it returns
annotation subtype. Also, CPDFSDK_Annot::GetSubType is only used to check if
the annotation is signature widget. Thus, change the method to
IsSignatureWidget.  Lastly, rename CPDF_Annot::GetSubType to
CPDF_Annot::GetSubtype to match with spec.
==========

[jaepark, 2016-08-26 21:44:55]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-26 21:45:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 22:06:25]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-26 22:08:11]

https://codereview.chromium.org/2287703002/diff/1/fpdfsdk/cba_annotiterator.cpp
File fpdfsdk/cba_annotiterator.cpp (right):

https://codereview.chromium.org/2287703002/diff/1/fpdfsdk/cba_annotiterator.c...
fpdfsdk/cba_annotiterator.cpp:129: pAnnot->GetSubType() == m_sSubType)
On 2016/08/26 21:16:13, Lei Zhang wrote:
> There's some SubType vs Subtype inconsistencies.

Done.

I changed the GetSubType method to IsSignatureWidget() since
CPDFSDK_Annot::GetSubType only checks whether or not it is signature widget.

[Lei Zhang, 2016-08-26 22:24:17]

lgtm

[jaepark, 2016-08-26 23:15:50]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-08-26 23:15:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 23:16:12]

Description was changed from

==========
Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

CPDFSDK_Annot::GetType should be renamed to GetAnnotSubtype as it returns
annotation subtype. Also, CPDFSDK_Annot::GetSubType is only used to check if
the annotation is signature widget. Thus, change the method to
IsSignatureWidget.  Lastly, rename CPDF_Annot::GetSubType to
CPDF_Annot::GetSubtype to match with spec.
==========

to

==========
Rename CPDFSDK_Annot::GetType to CPDFSDK_Annot::GetAnnotSubtype.

CPDFSDK_Annot::GetType should be renamed to GetAnnotSubtype as it returns
annotation subtype. Also, CPDFSDK_Annot::GetSubType is only used to check if
the annotation is signature widget. Thus, change the method to
IsSignatureWidget.  Lastly, rename CPDF_Annot::GetSubType to
CPDF_Annot::GetSubtype to match with spec.

Committed:
https://pdfium.googlesource.com/pdfium/+/9ed91376d562f3c6e7ca0a99035a74502f64...
==========

[commit-bot: I haz the power, 2016-08-26 23:16:13]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9ed91376d562f3c6e7ca0a99035a74502f64...