Use StringView in Dictionary and DictionaryHelper.

Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
Committed: https://crrev.com/f2c9273fe51951b3cb68cc7fe634cc91265cce41
Cr-Commit-Position: refs/heads/master@{#415549}

[esprehn, 2016-08-29 23:02:32]

Description was changed from

==========
Use StringView in Dictionary and DictionaryHelper.

BUG=615174
==========

to

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

[esprehn, 2016-08-29 23:02:36]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 23:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:07:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 04:07:16]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-08-30 06:40:50]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, peria@chromium.org

[Yuki, 2016-08-30 06:50:30]

Description was changed from

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

to

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

[haraken, 2016-08-30 09:21:20]

LGTM

For some historical reasons, we have mixed 'String' and 'const String &' in the
code base, although 'const String&' should be faster than 'String'. What about
StringView? Is 'const StringView&' faster than 'StringView'? i.e., should we try
to use 'const StringView&' as much as possible?

[esprehn, 2016-08-30 09:57:03]

On 2016/08/30 at 09:21:20, haraken wrote:
> LGTM
> 
> For some historical reasons, we have mixed 'String' and 'const String &' in
the code base, although 'const String&' should be faster than 'String'. What
about StringView? Is 'const StringView&' faster than 'StringView'? i.e., should
we try to use 'const StringView&' as much as possible?

That's a good question, the internal threads about StringPiece are divided.
StringView is one pointer larger than a StringPiece as well. It also doesn't
have any branches in it like the RefPtr churn that String causes. I think when I
asked Jeffery he said it probably doesn't matter and that passing by value might
be slightly faster.

Perhaps we should mass replace all of the StringView& with by value?

[esprehn, 2016-08-30 09:57:15]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-30 09:57:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 10:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 10:03:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-08-30 10:12:30]

On 2016/08/30 09:57:03, esprehn wrote:
> On 2016/08/30 at 09:21:20, haraken wrote:
> > LGTM
> > 
> > For some historical reasons, we have mixed 'String' and 'const String &' in
> the code base, although 'const String&' should be faster than 'String'. What
> about StringView? Is 'const StringView&' faster than 'StringView'? i.e.,
should
> we try to use 'const StringView&' as much as possible?
> 
> That's a good question, the internal threads about StringPiece are divided.
> StringView is one pointer larger than a StringPiece as well. It also doesn't
> have any branches in it like the RefPtr churn that String causes. I think when
I
> asked Jeffery he said it probably doesn't matter and that passing by value
might
> be slightly faster.
> 
> Perhaps we should mass replace all of the StringView& with by value?

Yeah, that sounds reasonable :)

[esprehn, 2016-08-30 16:09:59]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:10:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:16:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[esprehn, 2016-08-31 00:14:27]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:14:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 00:18:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:18:15]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[esprehn, 2016-08-31 00:20:40]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2016-08-31 00:20:40]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2285183005/#ps20001
(title: "rebase.")

[commit-bot: I haz the power, 2016-08-31 00:21:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 03:04:02]

Description was changed from

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

to

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

[commit-bot: I haz the power, 2016-08-31 03:04:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-31 03:05:38]

Description was changed from

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174
==========

to

==========
Use StringView in Dictionary and DictionaryHelper.

This lets us avoid all of the string copies and externalization costs for the
key names when getting properties.

BUG=615174

Committed: https://crrev.com/f2c9273fe51951b3cb68cc7fe634cc91265cce41
Cr-Commit-Position: refs/heads/master@{#415549}
==========

[commit-bot: I haz the power, 2016-08-31 03:05:39]

Patchset 2 (id:??) landed as
https://crrev.com/f2c9273fe51951b3cb68cc7fe634cc91265cce41
Cr-Commit-Position: refs/heads/master@{#415549}