third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp - Issue 2285183005: Use StringView in Dictionary and DictionaryHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp

Issue 2285183005: Use StringView in Dictionary and DictionaryHelper. (Closed)

Patch Set: rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp

diff --git a/third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp b/third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp

index ed76c4e47fde560cabbb227ff1f820466c2809d1..8f9e931b3b6646ae67b494beb4641cce5d638324 100644

--- a/third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp

+++ b/third_party/WebKit/Source/bindings/modules/v8/DictionaryHelperForModules.cpp

@@ -29,7 +29,7 @@

namespace blink {

-template bool DictionaryHelper::get(const Dictionary&, const String& key, Member<Headers>& value);

-template bool DictionaryHelper::get(const Dictionary&, const String& key, Member<PasswordCredential>& value);

+template bool DictionaryHelper::get(const Dictionary&, const StringView& key, Member<Headers>& value);

+template bool DictionaryHelper::get(const Dictionary&, const StringView& key, Member<PasswordCredential>& value);

} // namespace blink

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/DictionaryHelperForCore.cpp ('k') | no next file » | no next file with comments »