Use StringView in Dictionary and DictionaryHelper.

third_party/WebKit/Source/bindings/core/v8/Dictionary.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 11 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef Dictionary_h
 #define Dictionary_h
 
 #include "bindings/core/v8/DictionaryIterator.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/Nullable.h"
-#include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
-#include "bindings/core/v8/V8BindingMacros.h"
 #include "core/CoreExport.h"
 #include "wtf/HashMap.h"
-#include "wtf/HashSet.h"
 #include "wtf/Vector.h"
-#include "wtf/text/AtomicString.h"
-#include "wtf/text/WTFString.h"
+#include "wtf/text/StringView.h"
 #include <v8.h>
 
 namespace blink {
 
 class ExceptionState;
 class ExecutionContext;
 
 // Dictionary class provides ways to retrieve property values as C++ objects
 // from a V8 object. Instances of this class must not outlive V8's handle scope
 // because they hold a V8 value without putting it on persistent handles.
 class CORE_EXPORT Dictionary final {
     DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
 public:
     Dictionary()
         : m_isolate(nullptr) { }
     Dictionary(v8::Isolate* isolate, const v8::Local<v8::Value>& options)
         : m_options(options)
         , m_isolate(isolate)
     {
         DCHECK(m_isolate);
     }
     Dictionary(const v8::Local<v8::Value>& options, v8::Isolate* isolate, ExceptionState&) // DEPRECATED
         : Dictionary(isolate, options) { }
 
     Dictionary& operator=(const Dictionary&);
 
     bool isObject() const;
     bool isUndefinedOrNull() const;
 
-    bool get(const String&, Dictionary&) const;
-    bool get(const String&, v8::Local<v8::Value>&) const;
+    bool get(const StringView&, Dictionary&) const;
+    bool get(const StringView&, v8::Local<v8::Value>&) const;
 
     v8::Local<v8::Value> v8Value() const { return m_options; }
 
     bool getOwnPropertiesAsStringHashMap(HashMap<String, String>&) const;
     bool getPropertyNames(Vector<String>&) const;
 
-    bool hasProperty(const String&) const;
+    bool hasProperty(const StringView&) const;
 
     v8::Isolate* isolate() const { return m_isolate; }
     v8::Local<v8::Context> v8Context() const
     {
         ASSERT(m_isolate);
         return m_isolate->GetCurrentContext();
     }
 
-    bool getKey(const String& key, v8::Local<v8::Value>&) const;
     DictionaryIterator getIterator(ExecutionContext*) const;
 
 private:
     bool getInternal(const v8::Local<v8::Value>& key, v8::Local<v8::Value>& result) const;
     bool toObject(v8::Local<v8::Object>&) const;
 
     v8::Local<v8::Value> m_options;
     v8::Isolate* m_isolate;
 };
 
 template<>
 struct NativeValueTraits<Dictionary> {
     static inline Dictionary nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState&)
     {
         return Dictionary(isolate, value);
     }
 };
 
 // DictionaryHelper is a collection of static methods for getting or
 // converting a value from Dictionary.
 struct DictionaryHelper {
     STATIC_ONLY(DictionaryHelper);
     template <typename T>
-    static bool get(const Dictionary&, const String& key, T& value);
+    static bool get(const Dictionary&, const StringView& key, T& value);
     template <typename T>
-    static bool get(const Dictionary&, const String& key, T& value, bool& hasValue);
+    static bool get(const Dictionary&, const StringView& key, T& value, bool& hasValue);
     template <typename T>
-    static bool get(const Dictionary&, const String& key, T& value, ExceptionState&);
+    static bool get(const Dictionary&, const StringView& key, T& value, ExceptionState&);
     template <typename T>
-    static bool getWithUndefinedOrNullCheck(const Dictionary& dictionary, const String& key, T& value)
+    static bool getWithUndefinedOrNullCheck(const Dictionary& dictionary, const StringView& key, T& value)
     {
         v8::Local<v8::Value> v8Value;
-        if (!dictionary.getKey(key, v8Value) || isUndefinedOrNull(v8Value))
+        if (!dictionary.get(key, v8Value) || isUndefinedOrNull(v8Value))
             return false;
         return DictionaryHelper::get(dictionary, key, value);
     }
     template <template <typename> class PointerType, typename T>
-    static bool get(const Dictionary&, const String& key, PointerType<T>& value);
+    static bool get(const Dictionary&, const StringView& key, PointerType<T>& value);
 };
 
 } // namespace blink
 
 #endif // Dictionary_h