Use StringView in Dictionary and DictionaryHelper.

third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/Dictionary.h"
 
 #include "bindings/core/v8/ArrayValue.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ScriptController.h"
 #include "bindings/core/v8/V8ArrayBufferView.h"
 #include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8DOMError.h"
 #include "bindings/core/v8/V8Element.h"
 #include "bindings/core/v8/V8EventTarget.h"
 #include "bindings/core/v8/V8MessagePort.h"
 #include "bindings/core/v8/V8TextTrack.h"
 #include "bindings/core/v8/V8VoidCallback.h"
 #include "bindings/core/v8/V8Window.h"
 #include "core/html/track/TrackBase.h"
 #include "wtf/MathExtras.h"
 
@@ skipping 11 matching lines @@
     return !isUndefinedOrNull() && m_options->IsObject();
 }
 
 bool Dictionary::isUndefinedOrNull() const
 {
     if (m_options.IsEmpty())
         return true;
     return blink::isUndefinedOrNull(m_options);
 }
 
-bool Dictionary::hasProperty(const String& key) const
+bool Dictionary::hasProperty(const StringView& key) const
 {
     v8::Local<v8::Object> object;
     if (!toObject(object))
         return false;
 
     DCHECK(m_isolate);
     DCHECK_EQ(m_isolate, v8::Isolate::GetCurrent());
-    v8::Local<v8::String> v8Key = v8String(m_isolate, key);
-    return v8CallBoolean(object->Has(v8Context(), v8Key));
+    return v8CallBoolean(object->Has(v8Context(), v8String(m_isolate, key)));
 }
 
-bool Dictionary::getKey(const String& key, v8::Local<v8::Value>& value) const
+bool Dictionary::get(const StringView& key, v8::Local<v8::Value>& value) const
 {
     if (!m_isolate)
         return false;
-
     return getInternal(v8String(m_isolate, key), value);
 }
 
 DictionaryIterator Dictionary::getIterator(ExecutionContext* executionContext) const
 {
     v8::Local<v8::Value> iteratorGetter;
     // TODO(alancutter): Support callable objects as well as functions.
     if (!getInternal(v8::Symbol::GetIterator(m_isolate), iteratorGetter) || !iteratorGetter->IsFunction())
         return nullptr;
     v8::Local<v8::Value> iterator;
     if (!v8Call(V8ScriptRunner::callFunction(v8::Local<v8::Function>::Cast(iteratorGetter), executionContext, m_options, 0, nullptr, m_isolate), iterator))
         return nullptr;
     if (!iterator->IsObject())
         return nullptr;
     return DictionaryIterator(v8::Local<v8::Object>::Cast(iterator), m_isolate);
 }
 
-bool Dictionary::get(const String& key, v8::Local<v8::Value>& value) const
-{
-    return getKey(key, value);
-}
-
-bool Dictionary::get(const String& key, Dictionary& value) const
+bool Dictionary::get(const StringView& key, Dictionary& value) const
 {
     v8::Local<v8::Value> v8Value;
-    if (!getKey(key, v8Value))
+    if (!get(key, v8Value))
         return false;
 
     if (v8Value->IsObject()) {
         ASSERT(m_isolate);
         ASSERT(m_isolate == v8::Isolate::GetCurrent());
         value = Dictionary(m_isolate, v8Value);
     }
 
     return true;
 }
@@ skipping 68 matching lines @@
 
     return true;
 }
 
 bool Dictionary::toObject(v8::Local<v8::Object>& object) const
 {
     return !isUndefinedOrNull() && m_options->ToObject(v8Context()).ToLocal(&object);
 }
 
 } // namespace blink